API v1 monitoring.json Profile Parameters no longer contain health.threshold.*

[zrhoffman]

I'm submitting a ...

• bug report

Traffic Control components affected ...

• Traffic Monitor
• Traffic Ops

Current behavior:

The /api/1.3/cdns/{name}/configs/monitoring.json and /api/2.0/cdns/{name}/configs/monitoring.json return Profiles with Health Threshold parameters structured differently than ATC 4.1.1 and before had them in. What they look like at 473d9c2:

          "health_threshold": {
            "availableBandwidthInKbps": {
              "Comparator": ">",
              "Val": 1750000
            },
            "loadavg": {
              "Comparator": "<",
              "Val": 25
            },
            "queryTime": {
              "Comparator": "<",
              "Val": 1000
            }

Expected behavior:

The /api/1.3/cdns/{name}/configs/monitoring.json and /api/2.0/cdns/{name}/configs/monitoring.json should use the same format as previous releases used:

trafficcontrol/docs/source/api/v2/cdns_name_configs_monitoring.rst

Lines 197 to 199 in 473d9c2

	"health.threshold.availableBandwidthInKbps": ">1750000",
	"health.threshold.loadavg": "25.0",
	"health.threshold.queryTime": 1000,

Minimal reproduction of the problem with instructions:

1. GET /api/1.3/cdns/{name}/configs/monitoring.json
2. Notice the Health Threshold Paramters are not in the expected format given above.

Anything else:

• This issue first appeared at 44d79af (Update /cdns/:name/configs/monitoring for multiple interfaces #4774).

• Attached:

  • A monitoring.json from API v1 at RELEASE-4.1.1
  • A monitoring.json from API v1 at master at 473d9c2

[zrhoffman]

Adding major label since this prevents Traffic Monitor from offlining caches whose available bandwidth does not meet health.threshold.availableBandwidthInKbps.