Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TO /deliveryservices/:id/routing makes requests to all TRs instead of by CDN #6197

Closed
rawlinp opened this issue Sep 13, 2021 · 2 comments · Fixed by #6288
Closed

TO /deliveryservices/:id/routing makes requests to all TRs instead of by CDN #6197

rawlinp opened this issue Sep 13, 2021 · 2 comments · Fixed by #6288
Assignees
Labels
bug something isn't working as intended Traffic Ops related to Traffic Ops
Milestone

Comments

@rawlinp
Copy link
Contributor

rawlinp commented Sep 13, 2021

This Bug Report affects these Traffic Control components:

  • Traffic Ops

Current behavior:

When a request is made to TO's GET /api/x/deliveryservices/:id/routing endpoint, TO makes a request to all TRs instead of just the TRs that belong to the same CDN as the given delivery service.

Expected behavior:

For this endpoint, TO should only make requests to TRs that belong to the CDN of the given delivery service.

Steps to reproduce:

GET /api/3.1/deliveryservices/<insert-ds-id-here>/routing

@rawlinp rawlinp added bug something isn't working as intended Traffic Ops related to Traffic Ops labels Sep 13, 2021
@rawlinp
Copy link
Contributor Author

rawlinp commented Sep 13, 2021

The issue is around this code:

func getCDNRouterFQDNs(tx *sql.Tx, requiredCDN *string) (map[tc.CDNName][]string, error) {

This API should pass a CDN name to this function instead of nil.

@srijeet0406
Copy link
Contributor

@rawlinp I can take this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended Traffic Ops related to Traffic Ops
Projects
None yet
3 participants