Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geo Limit Countries should be an array #6382

Closed
ocket8888 opened this issue Nov 25, 2021 · 1 comment · Fixed by #6441
Closed

Geo Limit Countries should be an array #6382

ocket8888 opened this issue Nov 25, 2021 · 1 comment · Fixed by #6441
Assignees
Labels
improvement The functionality exists but it could be improved in some way. low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution Traffic Ops API Next Improvements to Traffic Ops API - particularly breaking changes

Comments

@ocket8888
Copy link
Contributor

This Improvement request (usability, performance, tech debt, etc.) affects these Traffic Control components:

  • Traffic Ops

Current behavior:

Currently, it's a string that represents an array of strings separated by commas e.g. "US,CA".

New behavior:

Arrays should be arrays e.g. ["US", "CA"]. If the parser is smart enough (and if we care to do it this way), that could be done in a backward-compatible manner such that if the field is a string it's parsed as a comma-delimited array, and if it's an array it's parsed as such. With the right validation (currently it has none, but country codes can't, for example, legally contain commas) the storage format could even be kept the same, which not only obviates the need for a migration but trivializes supporting old API versions.

@ocket8888 ocket8888 added low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution Traffic Ops API Next Improvements to Traffic Ops API - particularly breaking changes improvement The functionality exists but it could be improved in some way. low difficulty the estimated level of effort to resolve this issue is low labels Nov 25, 2021
@srijeet0406
Copy link
Contributor

@ocket8888 I can take this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement The functionality exists but it could be improved in some way. low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution Traffic Ops API Next Improvements to Traffic Ops API - particularly breaking changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants