Fix t3c version in build #6405
Merged
Fix t3c version in build #6405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob05c
added
cache-config
rob05c
force-pushed
the
fix-t3c-version
branch
from
547905a
to
4ea790c
Compare
Fixes the t3c build to properly add the ATC version, changeset, and monotonic version to the t3c version commands, as well as to t3c-generate generated files. Also adds the version flag to apps that were missing it.
rob05c
force-pushed
the
fix-t3c-version
branch
from
4ea790c
to
55ddcc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the t3c build to properly add the ATC version, changeset,
and monotonic version to the t3c version commands,
as well as to t3c-generate generated files.
Also adds the version flag to apps that were missing it.
I see this as a pretty big win for operations. Every time I install a new t3c version, the first thing I do is run it, and look at how the config files changed. Because production runs are on a schedule, it's difficult or impossible to figure out which exact git commit was the first new version run. This makes it easy to see in the file headers.
Includes changelog
Includes docs
Includes tests
Labelling
improvementrather thanbug, because even though some code existed the feature has never worked.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Install
trafficcontrol-cache-config, runt3c-* --version, verify version matches ATC version and includes git changeset.Run t3c, verify config file comment headers include ATC/RPM version and changeset.
If this is a bugfix, which Traffic Control versions contained the bug?
Not a bug.
PR submission checklist