Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User properties are only required sometimes #6776

Closed
ocket8888 opened this issue Apr 23, 2022 · 0 comments · Fixed by #6832
Closed

User properties are only required sometimes #6776

ocket8888 opened this issue Apr 23, 2022 · 0 comments · Fixed by #6832
Labels
bug something isn't working as intended low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops related to Traffic Ops

Comments

@ocket8888
Copy link
Contributor

Related to #6299 but somewhat of a bigger deal because using one endpoint can cause the other to give back a representation that can't be passed validly back to that same endpoint.

This Bug Report affects these Traffic Control components:

  • Traffic Ops

Current behavior:

The fields email and fullName are not allowed to be blank, missing, or null in PUT or POST requests to /users/{{ID}} and /users (respectively), but are allowed to be any of those things in PUT requests to /user/current. So you can put your user in a state where it can't be updated via PUT /users/{{ID}} without fixing pre-existing issues, which could cause problems in a situation where there isn't a human around to intervene.

Also, a PUT request to /user/current, because it incorrectly behaves more like a PATCH, doesn't require other fields - Role ID, username, and tenantID/tenantId whereas /users does. That's not as big a deal, though, because it leaves them unchanged when not specified.

Expected behavior:

Our users API should make sense

Steps to reproduce:

Edit yourself to have a null fullName, then try to update your addressLine1 using a PUT request to /users

@ocket8888 ocket8888 added bug something isn't working as intended Traffic Ops related to Traffic Ops low impact affects only a small portion of a CDN, and cannot itself break one low difficulty the estimated level of effort to resolve this issue is low labels Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant