Change t3c h2 disable to enable #6944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob05c
added
bug
rob05c
force-pushed
the
change-t3c-h2-disable-to-enable
branch
2 times, most recently
from
8db60b1
to
5ed892f
Compare
ATS 9 is documented as allowing the disable_h2 directive in sni.yaml (albiet deprecated). But it doesn't seem to work. This changes cache config gen to generate the newer http2 directive instead.
rob05c
force-pushed
the
change-t3c-h2-disable-to-enable
branch
from
5ed892f
to
a108281
Compare
ocket8888
approved these changes
Jul 18, 2022
|
Closes #6816 |
zrhoffman
pushed a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Oct 2, 2022
ATS 9 is documented as allowing the disable_h2 directive in sni.yaml (albiet deprecated). But it doesn't seem to work. This changes cache config gen to generate the newer http2 directive instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change t3c sni.yaml disable_h2 to http2 directive
ATS 9 is documented as allowing the disable_h2 directive in sni.yaml
(albiet deprecated). But it doesn't seem to work.
This changes cache config gen to generate the newer http2 directive
instead.
I'm labelling
bugbecause even though this isn't a bug per the ATS documentation, it appears to create a behavioral bug in-practice.Which Traffic Control components are affected by this PR?
t3c, formerly ORT)What is the best way to verify this PR?
Generate cache config, verify sni.yaml has
http2:directives instead ofdisable_h2directives. Run ATS 9 with generated config, verify ATS enables or disables H2 appropriately.If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist
[x] This PR has documentationno docs, details of cache config generated files are not documented