Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cookie user errors from TO error.log #7134

Closed
ericholguin opened this issue Oct 13, 2022 · 3 comments · Fixed by #7138
Closed

Remove cookie user errors from TO error.log #7134

ericholguin opened this issue Oct 13, 2022 · 3 comments · Fixed by #7138
Labels
improvement The functionality exists but it could be improved in some way.

Comments

@ericholguin
Copy link
Contributor

Currently, if a user's cookie is expired or has an incorrect signature these will log as errors in error.log, however this is normal functionality and a user error not a system error that needs to be logged in error.log.

This Improvement request (usability, performance, tech debt, etc.) affects these Traffic Control components:

  • Traffic Ops

Current behavior:

error.log:

ERROR: api.go:263: --- error parsing cookie: bad signature
ERROR: api.go:263: --- error parsing cookie: signature expired

New behavior:

The error's above should no longer appear in error.log

@ericholguin ericholguin added the improvement The functionality exists but it could be improved in some way. label Oct 13, 2022
@smalenfant
Copy link
Contributor

Is this coming from a Client that doesn't observe the expiration?

@ericholguin
Copy link
Contributor Author

Yes, in this case I believe t3c isn't observing that expiration.

@ocket8888
Copy link
Contributor

Yeah, the official TO Go client does that. You can see it in the logs for CDN-in-a-Box coming from TM and t3c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement The functionality exists but it could be improved in some way.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants