Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing Delivery Services are not full representations #7189

Open
ocket8888 opened this issue Nov 14, 2022 · 0 comments
Open

Testing Delivery Services are not full representations #7189

ocket8888 opened this issue Nov 14, 2022 · 0 comments
Labels
low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution tests related to tests and/or testing infrastructure TO Client (Go) related to the Go implementation of a TC client

Comments

@ocket8888
Copy link
Contributor

This Improvement request (usability, performance, tech debt, etc.) affects these Traffic Control components:

  • Traffic Ops Client (Go) (Tests)

Current behavior:

In the tc-fixtures of (at least) the v4 and v5 client/API integration tests, the listed Delivery Services are not full representations of Delivery Services. Specifically, they are known to be missing the regional field, which relies on our parser's behavior of not throwing errors when fields are missing. This is technically in violation of the HTTP spec, since it makes our PUT requests not necessarily idempotent.

New behavior:

Our testing data should ideally include only complete representations of the objects they represent.
@ocket8888 ocket8888 added low impact affects only a small portion of a CDN, and cannot itself break one tests related to tests and/or testing infrastructure tech debt rework due to choosing easy/limited solution TO Client (Go) related to the Go implementation of a TC client low difficulty the estimated level of effort to resolve this issue is low labels Nov 14, 2022
@ocket8888 ocket8888 mentioned this issue Nov 14, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution tests related to tests and/or testing infrastructure TO Client (Go) related to the Go implementation of a TC client
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ocket8888