Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TC-291] GenIso can't handle concurrent requests #892

Closed
limited opened this issue Aug 29, 2017 · 1 comment
Closed

[TC-291] GenIso can't handle concurrent requests #892

limited opened this issue Aug 29, 2017 · 1 comment
Labels
high impact impacts the basic function, deployment, or operation of a CDN new feature A new feature, capability or behavior Traffic Ops related to Traffic Ops

Comments

@limited
Copy link
Contributor

limited commented Aug 29, 2017

Because GenIso always changes the same files (no temporary directories created), it can't handle concurrent requests. We sometimes send commands to create 10 Edge Caches at the same time and we found out that the wrong IP address shows up on servers.

I've got the code to fix it up (but need to sign our paperwork). But our GenIso.pm now deviates from what's in Traffic Ops because we wanted to keep the 1.0.0 functionality (don't use the install_cfg directory, keep using the simple network line).

Suggestion: We should have a parameter to call different ISO generator scripts. Seems like this is implementation specific and not really a core function of Traffic Ops.

Basic changes :

use File::Temp;
use File::Copy::Recursive;

my $tmpdir = File::Temp::tempdir(CLEANUP => 1);
...
GenIso.pm: my $tmp = File::Copy::Recursive::dircopy($dir,$tmpdir);
GenIso.pm: my $cfg_dir = "$tmpdir/$install_cfg";
GenIso.pm: print STUF "Dir== $tmpdir\n";
GenIso.pm: my $cmd = "mkisofs -joliet-long -input-charset utf-8 -b isolinux/isolinux.bin -c isolinux/boot.cat -no-emul-boot -boot-load-size 4 -boot-info-table -R -J -v -T $tmpdir";
GenIso.pm: open(IN, "<$tmpdir/ks.src") || die("$tmpdir/ks.src:$!");
GenIso.pm: open (OUT, ">$tmpdir/ks.cfg") || die("$tmpdir/ks.cfg:$!");
GenIso.pm: File::Path::rmtree $tmpdir;

Author: Dewayne Richardson
JIRA Link: https://issues.apache.org/jira/browse/TC-291
Found Version: 2.1.0

@limited limited added this to the 2.1.0 milestone Aug 29, 2017
@limited limited added Improvement high impact impacts the basic function, deployment, or operation of a CDN Traffic Ops related to Traffic Ops labels Aug 29, 2017
@hbeatty hbeatty modified the milestones: 2.2.0, 2.1.0 Aug 30, 2017
@rob05c rob05c added new feature A new feature, capability or behavior and removed improvement labels Jan 26, 2018
@rob05c rob05c modified the milestones: 2.2.0, 2.3 Jan 29, 2018
@dewrich
Copy link
Contributor

dewrich commented Oct 18, 2018

Still an issue

@awilliams awilliams mentioned this issue Nov 6, 2019
1 task
@dneuman64 dneuman64 removed this from the 2.3 milestone Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high impact impacts the basic function, deployment, or operation of a CDN new feature A new feature, capability or behavior Traffic Ops related to Traffic Ops
Projects
None yet
Development

No branches or pull requests

6 participants