Traffic Portal should filter out the "ALL" CDN option for snapshotting and queuing updates

[rawlinp]

This Improvement request (usability, performance, tech debt, etc.) affects these Traffic Control components:

• Traffic Portal

Current behavior:

When snapshotting or queuing updates in Traffic Portal, the ALL CDN is listed as an option:

New behavior:

The ALL CDN should not be listed as an option in the snapshot and queue update modals, because it is never valid to snapshot or queue updates for the ALL CDN.

[mitchell852]

that's odd. i don't recall it doing that...but indeed it does. feels like a regression bug.

[mitchell852]

in addition. on the ALL cdn page (https://tp.domain.tld/#!/cdns/{{all_cdn_id}}), those options should not exist:

[ocket8888]

If we really want to treat ALL specially, then we need to make that more formal. It should be immutable, it shouldn't be allowed to contain Delivery Services, etc. Currently, there are some places that treat ALL specially, and some that don't, and it can lead you to a partly correct configuration. It's also not documented anywhere that ALL is special and shouldn't be used for certain things.

IMO, we should actually just not treat ALL specially, and get rid of the notion of some special CDN that isn't really a CDN but sometimes is. If servers don't belong to a CDN, then they can just have null CDNs.

[mitchell852]

IMO, we should actually just not treat ALL specially, and get rid of the notion of some special CDN that isn't really a CDN but sometimes is. If servers don't belong to a CDN, then they can just have null CDNs.

sure but that's a bigger effort and would require some thought on the plan. for now, i'll hide the ALL cdn from operations it was not designed to support as it was before. PR coming...this is a regression bug that was introduced when i added cdn notifications and decided to use the ALL cdn for that. i would definitely welcome the removal of the ALL cdn #3355

[rawlinp]

@ocket8888 I agree with your sentiments about the ALL CDN, but I do also think it's worth it to treat it specially in certain cases until such a time that we can separate cache servers from non-cache servers, especially since this does seem like a UI regression like @mitchell852 said.