Reallocate a buffer for H2 header block only if needed (#10568)

Co-authored-by: Bryan Call <bcall@apache.org> (cherry picked from commit 65dd186)
apache · Oct 9, 2023 · 4ca137b · 4ca137b
1 parent a49e575
commit 4ca137b
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/proxy/http2/Http2ConnectionState.cc b/proxy/http2/Http2ConnectionState.cc
@@ -937,8 +937,10 @@ rcv_continuation_frame(Http2ConnectionState &cstate, const Http2Frame &frame)
                       "header blocks too large");
   }
 
-  stream->header_blocks = static_cast<uint8_t *>(ats_realloc(stream->header_blocks, stream->header_blocks_length));
-  frame.reader()->memcpy(stream->header_blocks + header_blocks_offset, payload_length);
+  if (payload_length > 0) {
+    stream->header_blocks = static_cast<uint8_t *>(ats_realloc(stream->header_blocks, stream->header_blocks_length));
+    frame.reader()->memcpy(stream->header_blocks + header_blocks_offset, payload_length);
+  }
 
   if (frame.header().flags & HTTP2_FLAGS_HEADERS_END_HEADERS) {
     // NOTE: If there are END_HEADERS flag, decode stored Header Blocks.