Make the rest of InkAPI allocators Proxy Allocated (#8106)

* Make the rest of InkAPI allocators Proxy Allocated * As per Walt the all-knowing oracle, remove from test (cherry picked from commit e6a7603)
apache · Jul 28, 2021 · 8116951 · 8116951
1 parent 8a8f1b7
commit 8116951
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 33 deletions.
diff --git a/iocore/eventsystem/I_Thread.h b/iocore/eventsystem/I_Thread.h
@@ -137,6 +137,10 @@ class Thread
   ProxyAllocator ioDataAllocator;
   ProxyAllocator ioAllocator;
   ProxyAllocator ioBlockAllocator;
+  // From InkAPI (plugins wrappers)
+  ProxyAllocator apiHookAllocator;
+  ProxyAllocator INKContAllocator;
+  ProxyAllocator INKVConnAllocator;
   ProxyAllocator mHandleAllocator;
 
   /** Start the underlying thread.

diff --git a/src/traffic_server/InkAPI.cc b/src/traffic_server/InkAPI.cc
@@ -1074,7 +1074,7 @@ INKContInternal::free()
   clear();
   this->mutex.clear();
   m_free_magic = INKCONT_INTERN_MAGIC_DEAD;
-  INKContAllocator.free(this);
+  THREAD_FREE(this, INKContAllocator, this_thread());
 }
 
 void
@@ -1180,7 +1180,7 @@ INKVConnInternal::free()
   clear();
   this->mutex.clear();
   m_free_magic = INKCONT_INTERN_MAGIC_DEAD;
-  INKVConnAllocator.free(this);
+  THREAD_FREE(this, INKVConnAllocator, this_thread());
 }
 
 void
@@ -1385,7 +1385,7 @@ APIHooks::append(INKContInternal *cont)
 {
   APIHook *api_hook;
 
-  api_hook         = apiHookAllocator.alloc();
+  api_hook         = THREAD_ALLOC(apiHookAllocator, this_thread());
   api_hook->m_cont = cont;
 
   m_hooks.enqueue(api_hook);
@@ -1396,7 +1396,7 @@ APIHooks::clear()
 {
   APIHook *hook;
   while (nullptr != (hook = m_hooks.pop())) {
-    apiHookAllocator.free(hook);
+    THREAD_FREE(hook, apiHookAllocator, this_thread());
   }
 }
 
@@ -4598,7 +4598,7 @@ TSContCreate(TSEventFunc funcp, TSMutex mutexp)
     pluginThreadContext->acquire();
   }
 
-  INKContInternal *i = INKContAllocator.alloc();
+  INKContInternal *i = THREAD_ALLOC(INKContAllocator, this_thread());
 
   i->init(funcp, mutexp, pluginThreadContext);
   return (TSCont)i;
@@ -7069,7 +7069,7 @@ TSVConnCreate(TSEventFunc event_funcp, TSMutex mutexp)
     pluginThreadContext->acquire();
   }
 
-  INKVConnInternal *i = INKVConnAllocator.alloc();
+  INKVConnInternal *i = THREAD_ALLOC(INKVConnAllocator, this_thread());
 
   sdk_assert(sdk_sanity_check_null_ptr((void *)i) == TS_SUCCESS);
 

diff --git a/tests/tools/plugins/test_hooks.cc b/tests/tools/plugins/test_hooks.cc
@@ -344,30 +344,3 @@ TSPluginInit(int argc, const char *argv[])
 
   tCont = TSContCreate(transactionContFunc, mtx);
 }
-
-namespace
-{
-class Cleanup
-{
-public:
-  ~Cleanup()
-  {
-    // In practice it is not strictly necessary to destroy remaining continuations on program exit.
-
-    if (tCont) {
-      TSContDestroy(tCont);
-    }
-    if (sCont) {
-      TSContDestroy(sCont);
-    }
-    if (gCont) {
-      TSContDestroy(gCont);
-    }
-  }
-};
-
-// Do any needed cleanup for this source file at program termination time.
-//
-Cleanup cleanup;
-
-} // namespace