Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paft of tcp_congestion_control code was erased by push TS-3612 #1399

Closed
shenzhang920 opened this issue Jan 31, 2017 · 2 comments
Closed

Paft of tcp_congestion_control code was erased by push TS-3612 #1399

shenzhang920 opened this issue Jan 31, 2017 · 2 comments
Labels
Core Regression

Comments

@shenzhang920
Copy link

ATS can change the tcp_congestion_control algorithm on both client side and server side, this functionality was added in 5.x. The push of TS-3612 accidentally remove some part of the code. (by removing HttpClientSession.cc and adding Http1ClientSession.cc/Http2ClientSession.cc, some of the code in HttpClientSession.cc was missing)
@bryancall bryancall added the Core label Jan 31, 2017
maskit pushed a commit that referenced this issue Feb 9, 2017
@maskit
isuue #1399 add back partial code of tcp_congestion_control erased by…
f71b75e 
… TS-3612
maskit pushed a commit to maskit/trafficserver that referenced this issue Feb 9, 2017
@maskit
isuue apache#1399 add back partial code of tcp_congestion_control era…
bdb771c 
…sed by TS-3612
@shenzhang920 shenzhang920 mentioned this issue Feb 9, 2017
Closed
@maskit maskit mentioned this issue Feb 9, 2017
Closed
PSUdaemon pushed a commit that referenced this issue Feb 10, 2017
@PSUdaemon
issue #1399 add back partial code of tcp_congestion_control erased by…
4c4d646 
… TS-3612

(cherry picked from commit f71b75e)
@maskit
Copy link
Member

maskit commented Feb 14, 2017

@shenzhang920 Thank you for the pull-requests and your patience.
The fix has been merged on master and 6.2.x.

@zwoop This is not a critical issue but I think we should backport the fix to 7.1 too, or it will be degradation when migrating from 6.2.2 to 7.1.x.
Please let me know if you want me to send a pull-request for 7.1.

@maskit maskit mentioned this issue Mar 9, 2017
Merged
zwoop pushed a commit that referenced this issue Mar 10, 2017
@zwoop
isuue #1399 add back partial code of tcp_congestion_control erased by…
d78c2d7 
… TS-3612

(cherry picked from commit f71b75e)
@maskit
Copy link
Member

maskit commented Mar 10, 2017

Fixed on 6.2.x, 7.1.x and master.

@maskit maskit closed this as completed Mar 10, 2017
masaori335 pushed a commit to masaori335/trafficserver that referenced this issue Nov 6, 2017
Merge branch 'asf/master'
f4dc371 
* asf/master: (75 commits)
  npn string should be updated on unregistering a protocol as well
  Remove cluster from README, it is going away
  Fix a build issue that use of undeclared variables
  Backport unused dependency check to Python 2.6
  isuue apache#1399 add back partial code of tcp_congestion_control erased by TS-3612
  Configure option to disable CURL
  Only apply the --as-needed linker flags to Linux.
  Prune some unused library dependencies
  TS-1878: Add --as-needed to the linker flags
  Replace EXTRA_CXX_LDFLAGS with AM_LDFLAGS
  X509 was made opaque in OpenSSL 1.1
  OpenSSL 1.1 ASN1_STRING_data() and RAND_pseudo_bytes()
  TS-2095: TS_HAS_LIBZ and TS_HAS_LZMA are always false
  Fix indentation on previous docs update
  retry safe requests
  Fix for YTSATS-983
  Add diags log message when cache wraps.
  Update default debug tags to not create a misleading understanding of how tag matching works.
  Move clang-analyzer results to a branch subdir
  TS-2274: Drop vestigial Autoconf output variable
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Core Regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maskit @zwoop @bryancall @shenzhang920