Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Quotation marks removed for numeric values #100

Closed
wants to merge 3 commits into from

Conversation

saltukalakus
Copy link

In "Stats over Http" plugin, it is better if integer and floating values does not have quotation marks in JSON output. With this change, JSON output works with data loggers based on elasticsearch with minimal configuration.

@jpeach
Copy link
Contributor

jpeach commented Jul 31, 2014

Traffic Server counters are int64 ... can ElasticSearch deal with that, or is it constrained to JavaScript compatible numeric types?

@saltukalakus
Copy link
Author

It follows Java convention. See link. However you can configure each item with explicit mapping when required.

@@ -1 +0,0 @@
Subproject commit 880ca300e8fb7b432b9d25ed377db2102e4cb63d
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably not be part of the commit

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is by mistake. You can ignore this line.

@jpeach
Copy link
Contributor

jpeach commented Aug 19, 2014

OK, this needs to be a plugin option then. Some consumers will expect javascript types and others will prefer richer integral types. The best thing to do here might be to serve 2 endpoints with the different semantics.

@jpeach
Copy link
Contributor

jpeach commented Sep 11, 2014

I have a patch that adds 2 new options to enable emitting JSON numbers, and to enable wrapping JSON numbers to int64.

@asfgit asfgit closed this in 454a2e5 Sep 11, 2014
hnakamur pushed a commit to hnakamur/trafficserver that referenced this pull request Jan 1, 2016
Doc: Update po files in reference/configuration/
SolidWallOfCode pushed a commit to SolidWallOfCode/trafficserver that referenced this pull request Mar 25, 2020
masaori335 pushed a commit to masaori335/trafficserver that referenced this pull request Mar 31, 2021
masaori335 added a commit to masaori335/trafficserver that referenced this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants