TS-4263: keyblock variable configurable via records.config #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| global_default_keyblock = ssl_create_ticket_keyblock(ticket_key_path); // this function just returns a keyblock | ||
| } | ||
| else | ||
| global_default_keyblock = ssl_create_ticket_keyblock(NULL); // this function just returns a keyblock |
There was a problem hiding this comment.
Please clang-format. All blocks must be enclosed in { }.
There was a problem hiding this comment.
I just did. Sorry I keep forgetting
persiaAziz-zz
force-pushed
the
TS-4263
branch
from
41b4827
to
8a3264a
Compare
| if (ticket_key_filename != NULL) { | ||
| ats_scoped_str ticket_key_path(Layout::relative_to(params->serverCertPathOnly, ticket_key_filename)); | ||
| global_default_keyblock = ssl_create_ticket_keyblock(ticket_key_path); // this function just returns a keyblock | ||
| } else |
There was a problem hiding this comment.
hmm strange.. clang-format is not doing that for me. I will do that manually
There was a problem hiding this comment.
Does that look ok?
persiaAziz-zz
force-pushed
the
TS-4263
branch
from
8a3264a
to
0064bec
Compare
|
Looks good to me. |
|
[approve ci] |
| global_default_keyblock = ssl_create_ticket_keyblock(ticket_key_path); // this function just returns a keyblock | ||
| } else { | ||
| global_default_keyblock = ssl_create_ticket_keyblock(NULL); // this function just returns a keyblock | ||
| } |
There was a problem hiding this comment.
A newline before and after this if/else would improve the readability.
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/781/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/677/ for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default value proxy.config.ssl.server.ticket_key.filename is set to NULL