-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TS-4263: keyblock variable configurable via records.config #1008
Conversation
global_default_keyblock = ssl_create_ticket_keyblock(ticket_key_path); // this function just returns a keyblock | ||
} | ||
else | ||
global_default_keyblock = ssl_create_ticket_keyblock(NULL); // this function just returns a keyblock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clang-format. All blocks must be enclosed in {
}
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just did. Sorry I keep forgetting
41b4827
to
8a3264a
Compare
if (ticket_key_filename != NULL) { | ||
ats_scoped_str ticket_key_path(Layout::relative_to(params->serverCertPathOnly, ticket_key_filename)); | ||
global_default_keyblock = ssl_create_ticket_keyblock(ticket_key_path); // this function just returns a keyblock | ||
} else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} else {
....
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm strange.. clang-format is not doing that for me. I will do that manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that look ok?
8a3264a
to
0064bec
Compare
Looks good to me. |
[approve ci] |
global_default_keyblock = ssl_create_ticket_keyblock(ticket_key_path); // this function just returns a keyblock | ||
} else { | ||
global_default_keyblock = ssl_create_ticket_keyblock(NULL); // this function just returns a keyblock | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A newline before and after this if/else
would improve the readability.
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/781/ for details. |
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/677/ for details. |
Default value proxy.config.ssl.server.ticket_key.filename is set to NULL