Remove support for session id based session resumption #11157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duke8253
force-pushed
the
11-Dev-remove_session_id_reuse
branch
from
94fb026
to
905843c
Compare
cmcfarlen
approved these changes
Mar 13, 2024
bneradt
pushed a commit
to bneradt/trafficserver
that referenced
this pull request
May 7, 2024
Conflicts are related to: apache#11157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, this change will be going into 11.x instead of 10.x, replacing PR #11155 .
As discussed in the email, since session id bases session resumption is barely used anymore (0.02% of the traffic on our production boxes), and we removed the session share plugin that shares session ids across boxes in a colo, I'm removing the support for session id based session resumption.
Also added some new autests, and fixed up the documentation.