rate_limit: Set initialized flag of SieveLru when loading yaml is done #11181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masaori335
commented
Mar 22, 2024
| @@ -135,6 +135,8 @@ SieveLru::parseYaml(const YAML::Node &node) | |||
| Dbg(dbg_ctl, "\twith perma-block rule: %s(%u, %u, %ld)", _name.c_str(), _permablock_limit, _permablock_threshold, | |||
| static_cast<long>(_permablock_max_age.count())); | |||
|
|
|||
| _initialized = true; | |||
There was a problem hiding this comment.
@zwoop is this good place to set the flag? if any better place you imagined, let me know.
|
[approve ci autest] |
zwoop
approved these changes
Mar 27, 2024
bryancall
approved these changes
Mar 29, 2024
|
Cherry-picked to 10.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rate_limit plugin keep saying "no IP reputation" with any config. It looks like the
SieveLru::_initializedflag never be true.