Don't delete QUIC stream until both read and write complete #11196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brbzull0
reviewed
Apr 1, 2024
| { | ||
| this->_handle_uni_stream_on_read_ready(event, vio); | ||
|
|
||
| QUICStreamVCAdapter *adapter = static_cast<QUICStreamVCAdapter *>(vio->vc_server); |
There was a problem hiding this comment.
would it make sense to check for adapter != nullptr or maybe an assert?
There was a problem hiding this comment.
That's already checked in Http3App::main_event_handler.
brbzull0
approved these changes
Apr 1, 2024
|
Cherry-picked to v10.0.x |
cmcfarlen
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Don't use reference for stream id * Don't delete QUIC stream until both read and write complete (cherry picked from commit b27449b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #11170.
Looks like it happens when write_compete happens before read_complete, and there was a FIXME comment about it. This PR fixes it.