rate_limit: Adds a --rate option for RPS limits #11271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwoop
force-pushed
the
RateLimitRate
branch
3 times, most recently
from
66cd3f7
to
b3d25e7
Compare
|
Being a token bucket algorithm, which refills tokens every 25ms evenly distributed, it's not 100% accurate. Doing a h2load test, full blast, with ATS configured with --rate=10000, I get This is 10,158 RPS which are not rejected, which is pretty close to the target of 10k. |
zwoop
force-pushed
the
RateLimitRate
branch
3 times, most recently
from
ff8a312
to
61d1fa4
Compare
ywkaras
reviewed
Apr 19, 2024
|
|
||
| #include "limiter.h" | ||
|
|
||
| BucketManager gBucketMngr; |
There was a problem hiding this comment.
Why not make all the members of BucketManager static, and delete the default and copy constructors? Why does it have protected members, what class would ever inherit from BucketManager?
masaori335
reviewed
Apr 22, 2024
bryancall
reviewed
Apr 22, 2024
|
|
||
| }; // End class BucketManager | ||
|
|
||
| extern BucketManager gBucketMngr; | ||
|
|
||
| // order must align with the above | ||
| static const char *types[] = { |
There was a problem hiding this comment.
Seeing this on the CI builds:
../plugins/experimental/rate_limit/limiter.h:168:20: error: 'suffixes' defined but not used [-Werror=unused-variable]
168 | static const char *suffixes[] = {
| ^~~~~~~~
../plugins/experimental/rate_limit/limiter.h:152:20: error: 'types' defined but not used [-Werror=unused-variable]
152 | static const char *types[] = {
| ^~~~~
cc1plus: note: unrecognized command-line option '-Wno-vla-extension' may have been intended to silence earlier diagnostics
zwoop
force-pushed
the
RateLimitRate
branch
2 times, most recently
from
6943114
to
9f3529c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.