Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ASan on CI Rocky preset #11332

Merged
merged 7 commits into from May 15, 2024
Merged

Enable ASan on CI Rocky preset #11332

merged 7 commits into from May 15, 2024

Conversation

masaori335
Copy link
Contributor

No description provided.

@masaori335 masaori335 added this to the 10.1.0 milestone May 8, 2024
@masaori335 masaori335 self-assigned this May 8, 2024
@masaori335
Copy link
Contributor Author

[approve ci]

@masaori335 masaori335 changed the title Add CI Rocky ASan preset Enable ASan on CI Rocky preset May 9, 2024
@masaori335 masaori335 requested a review from bneradt May 9, 2024 20:23
@masaori335
Copy link
Contributor Author

Following @bneradt's advice, enabling ASan on rocky instead of adding another preset.

@masaori335 masaori335 mentioned this pull request May 9, 2024
Open
@masaori335
Copy link
Contributor Author

gcc-toolset-11 doesn't like UBSan :(

/opt/rh/gcc-toolset-11/root/usr/bin/ld: cannot find -lubsan

bneradt
bneradt requested changes May 10, 2024
View reviewed changes
Copy link
Contributor

@bneradt bneradt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for setting on ci-rocky. It will be good to get this coverage in PR CI.

CMakePresets.json Outdated
Comment on lines 155 to 156
"CMAKE_CXX_FLAGS_DEBUG": "-g -fsanitize=address",
"CMAKE_C_FLAGS_DEBUG": "-g -fsanitize=address"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to use "ENABLE_ASAN": "ON", instead of setting the flags. That would be preferable. Can you also use ENABLE_ASAN for the other places in here that set those -fsanitize=address flags?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. For the other places, I'll open another PR.

@masaori335 masaori335 mentioned this pull request May 13, 2024
Merged
@masaori335
Copy link
Contributor Author

[approve ci rocky]

@masaori335 masaori335 merged commit 2a6cfef into apache:master May 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bneradt bneradt bneradt approved these changes

Assignees

@masaori335 masaori335

Labels
CI CMake
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@masaori335 @bneradt