Add pthread.h to pthread_np.h Autoconf check #1317
Conversation
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1321/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1215/ for details. |
| @@ -1516,6 +1515,9 @@ AC_CHECK_HEADERS([sys/types.h \ | |||
| editline/readline.h \ | |||
| ucred.h ]) | |||
|
|
|||
| # On OpenBSD, pthread.h must be included before pthread_np.h. #1306 | |||
There was a problem hiding this comment.
I don't think adding GitHub issues into comments is a good idea.
There was a problem hiding this comment.
I don't propose doing it in general, just in this case I don't have another citation for this claim about OpenBSD. If it isn't true for every instance of OpenBSD, someone might question why this is in there, and the issue explains that. There's always "blame", this is just less hassle for that person, I think. There are cases where we reference Jiras from comments, no?
|
[approve ci] |
|
I created a new PR for this and set the author to Jack Bates #2283 |
@jirib does this fix #1306?