Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify TSHttpTxnHookAdd to add hook only once #1320

Merged
merged 2 commits into from
Jan 18, 2017
Merged

Modify TSHttpTxnHookAdd to add hook only once #1320

merged 2 commits into from
Jan 18, 2017

Conversation

meeramn
Copy link
Contributor

@meeramn meeramn commented Jan 11, 2017

Change-Id: I45c9cdbe305e8b3d186beafb87ab5f8c5b03b757

@meeramn
Modify TSHttpTxnHookAdd to add hook only once
7323378 
Change-Id: I45c9cdbe305e8b3d186beafb87ab5f8c5b03b757
@zwoop zwoop added this to the 7.1.0 milestone Jan 13, 2017
@zwoop zwoop added the TS API label Jan 13, 2017
@zwoop
Copy link
Contributor

zwoop commented Jan 13, 2017

Marking this for 7.1.0, we really need this in.

@zwoop
Copy link
Contributor

zwoop commented Jan 17, 2017

[approve ci]

@SolidWallOfCode
Copy link
Member

Ship it.

zwoop
zwoop approved these changes Jan 17, 2017
View reviewed changes
Copy link
Contributor

@zwoop zwoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@atsci
Copy link

atsci commented Jan 17, 2017

Linux build failed! See https://ci.trafficserver.apache.org/job/Github-Linux/1231/ for details.

@zwoop
Copy link
Contributor

zwoop commented Jan 17, 2017

@meeramn Can you re-run clang-format and update the PR please?

@atsci
Copy link

atsci commented Jan 17, 2017

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1337/ for details.

@meeramn
[TS-5024] Ran clang-format.
ac43a4a 
Modify TSHttpTxnHookAdd to add hook only once.

Change-Id: I737ca666cc05f2e2e2006cbef7f6b5a68b0eb71f
@zwoop
Copy link
Contributor

zwoop commented Jan 18, 2017

[approve ci]

@meeramn
Copy link
Contributor Author

meeramn commented Jan 18, 2017

Ran clang-format and pushed the change.

@atsci
Copy link

atsci commented Jan 18, 2017

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1349/ for details.

@atsci
Copy link

atsci commented Jan 18, 2017

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1242/ for details.

@atsci
Copy link

atsci commented Jan 18, 2017

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1350/ for details.

@zwoop zwoop merged commit 78bd265 into apache:master Jan 18, 2017
@zwoop
Copy link
Contributor

zwoop commented Jan 18, 2017

Well, dammit, I screwed up, this really shouldn't have been merged, you really must squash multiple commits like this into one commit (now I landed one commit that is not correct). :-/

This was referenced Jan 18, 2017
Closed
Closed
@zwoop
Copy link
Contributor

zwoop commented Jan 18, 2017

Not going to do the reverts here, but please be careful going forward with squashing commits that are fixes / review comments.

@vmamidi vmamidi mentioned this pull request Jun 18, 2018
Closed
@jrushford jrushford mentioned this pull request Jun 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwoop zwoop zwoop approved these changes

@SolidWallOfCode SolidWallOfCode Awaiting requested review from SolidWallOfCode

Assignees
No one assigned
Labels
TS API
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@meeramn @zwoop @SolidWallOfCode @atsci