Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS-4716: OpenBSD mandir should be ${prefix}/man #1355

Merged
merged 2 commits into from
Jan 24, 2017
Merged

Conversation

jablko
Copy link
Contributor

@jablko jablko commented Jan 23, 2017

Fixes #1353

@atsci
Copy link

atsci commented Jan 23, 2017

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1362/ for details.

@atsci
Copy link

atsci commented Jan 23, 2017

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1255/ for details.

@bryancall bryancall added this to the 7.2.0 milestone Jan 24, 2017
@zwoop
Copy link
Contributor

zwoop commented Jan 24, 2017

I'm marking this for 7.1.0, since it's mostly benign, and generally useful.

@zwoop zwoop modified the milestones: 7.1.0, 7.2.0 Jan 24, 2017
Copy link
Contributor

@zwoop zwoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zwoop
Copy link
Contributor

zwoop commented Jan 24, 2017

Question: Why is this PR also modifying the Debian layout? That seems slightly non-intuitive considering the Summary from the PR (OpenBSD).

Update: I think I see, it's merely a cleanup (no change in actual path). Still +1.

@jablko jablko merged commit 69c760b into apache:master Jan 24, 2017
@jablko
Copy link
Contributor Author

jablko commented Jan 24, 2017

I'm marking this for 7.1.0, since it's mostly benign, and generally useful.

Sounds good, thanks! Merged.

Update: I think I see, it's merely a cleanup (no change in actual path). Still +1.

Yes, exactly. I noticed it while I was editing config.layout, so I put it in the same PR, but it has nothing to do with OpenBSD, so I made it a separate commit. What I should've done was also mention it in the PR description, and point out that it's just a cleanup. Next time!

@jablko jablko self-assigned this Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants