Cleans up ICC options, and some build issues #1451
Conversation
|
Linux build successful! See https://ci.trafficserver.apache.org/job/linux-github/1449/ for details. |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/freebsd-github/1555/ for details. |
|
clang-analyzer build successful! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/120/ for details. |
zwoop
force-pushed
the
ICC
branch
2 times, most recently
from
cee6d9d
to
d407f43
Compare
|
Linux build successful! See https://ci.trafficserver.apache.org/job/linux-github/1451/ for details. |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/freebsd-github/1558/ for details. |
|
clang-analyzer build successful! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/123/ for details. |
iocore/eventsystem/P_IOBuffer.h
Outdated
| @@ -694,6 +695,7 @@ TS_INLINE char &IOBufferReader::operator[](int64_t i) | |||
| } | |||
|
|
|||
| ink_release_assert(!"out of range"); | |||
| return default_ret[0]; | |||
There was a problem hiding this comment.
The real problem is ICC doesn't realize the assert never returns.
Although, I don't understand why static char zwoop = '0'; return zwoop; wouldn't work, rather than messing about with an array.
There was a problem hiding this comment.
Sure, I can try that.
| @@ -46,7 +46,7 @@ signal_check_handler(int signal, signal_handler_t handler) | |||
| sigact = (void *)oact.sa_sigaction; | |||
| } | |||
|
|
|||
| if (sigact != handler) { | |||
| if (sigact != (void *)handler) { | |||
There was a problem hiding this comment.
No C-style casts! static_cast<void*>(handler) although we should really rethink using void* in this context.
There was a problem hiding this comment.
I did look / try not using void *, but it turns out the sigaction is not the same type as the handler. So some casting would be needed.
And yeh, I'll change to amc style cast, only because you are the best, and currently sitting in the #1 spot on the ranking.
There was a problem hiding this comment.
Actually, I'm not gonna change this, because everything else in this file (in a many places) uses the C-style cast already.
This removes a number of the previous warning exclusions that we we used to do. We then also have to clean up the core code in a few places, sometimes looking slightly odd (e.g. the meaningless const that we have in a few places).
|
Linux build successful! See https://ci.trafficserver.apache.org/job/linux-github/1458/ for details. |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/freebsd-github/1564/ for details. |
|
clang-analyzer build successful! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/129/ for details. |
This removes a number of the previous warning exclusions that we
we used to do. We then also have to clean up the core code in a
few places, sometimes looking slightly odd (e.g. the meaningless
const that we have in a few places).