Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MemView: Change typed array access method in MemView. #1482

Merged
merged 1 commit into from
Feb 24, 2017
Merged

MemView: Change typed array access method in MemView. #1482

merged 1 commit into from
Feb 24, 2017

Conversation

SolidWallOfCode
Copy link
Member

This makes the naming more STL style, improving usability.

@atsci
Copy link

atsci commented Feb 22, 2017

Linux build failed! See https://ci.trafficserver.apache.org/job/linux-github/1496/ for details.

@atsci
Copy link

atsci commented Feb 22, 2017

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/freebsd-github/1602/ for details.

@atsci
Copy link

atsci commented Feb 22, 2017

Intel CC build successful! See https://ci.trafficserver.apache.org/job/icc-github/34/ for details.

@zwoop zwoop added the Core label Feb 22, 2017
@zwoop zwoop added this to the 7.2.0 milestone Feb 22, 2017
@zwoop zwoop self-requested a review February 22, 2017 22:49
@zwoop
Copy link
Contributor

zwoop commented Feb 22, 2017 •
edited

@SolidWallOfCode

$ make -j clang-format

AND, add the flipping script I wrote to your .git hooks :-/

$ cp tools/git/pre-commit .git/hooks/pre-commit

zwoop
zwoop previously requested changes Feb 22, 2017
View reviewed changes
Copy link
Contributor

@zwoop zwoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs clang-format.

@atsci
Copy link

atsci commented Feb 22, 2017

clang-analyzer build successful! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/166/ for details.

@atsci
Copy link

atsci commented Feb 22, 2017

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/freebsd-github/1603/ for details.

@atsci
Copy link

atsci commented Feb 22, 2017

Linux build successful! See https://ci.trafficserver.apache.org/job/linux-github/1497/ for details.

@atsci
Copy link

atsci commented Feb 22, 2017

Intel CC build successful! See https://ci.trafficserver.apache.org/job/icc-github/35/ for details.

@atsci
Copy link

atsci commented Feb 22, 2017

clang-analyzer build successful! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/167/ for details.

zwoop
zwoop approved these changes Feb 23, 2017
View reviewed changes
Copy link
Contributor

@zwoop zwoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SolidWallOfCode SolidWallOfCode dismissed zwoop’s stale review February 24, 2017 18:45

I did the clang format.

@SolidWallOfCode SolidWallOfCode merged commit 7ce75e6 into apache:master Feb 24, 2017
@zwoop zwoop modified the milestones: 7.2.0, 8.0.0 Apr 25, 2017
@SolidWallOfCode SolidWallOfCode deleted the MemView-1 branch May 20, 2018 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwoop zwoop zwoop approved these changes

Assignees

@SolidWallOfCode SolidWallOfCode

Labels
Core
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SolidWallOfCode @atsci @zwoop