Remove BisonHeaderToC++.sed

[jablko]

We can do without it, and less is more?

[SolidWallOfCode]

I'm not sure we can do without this. I know I had problems which lead me to do this which may be related to older versions of Bison. Note that it works for 3.0.4 compared to 2.7. My experience is that Bison versions on old operating systems we support tend to be very old. I will need to check this on older OS versions we use here at Y!.

Additionally the plan going forward for this is to remove all the parsing from TSConfig and have it depend on Lua.

[jablko]

I'm not sure we can do without this. I know I had problems which lead me to do this which may be related to older versions of Bison. Note that it works for 3.0.4 compared to 2.7. My experience is that Bison versions on old operating systems we support tend to be very old. I will need to check this on older OS versions we use here at Y!.

Thanks for taking a look! It should work with Bison 2.7, just based on the GitHub CI jobs (e.g. the FreeBSD job uses 2.7 [1]). The CentOS 6 machine uses 2.4 [2] -- but we don't run that for pull requests, I think.

I think the important difference between TsConfigGrammar.h and TsConfigGrammar.hpp is that TsConfigGrammar.h contains yyscan_t (the first tsconfigparse() parameter) and TsConfigGrammar.hpp doesn't -- but replacing %parse-param { yyscan_t lexer } with %parse-param { void *lexer } has the same effect?

[1] https://ci.trafficserver.apache.org/files/BuildMachines/FreeBSD10
[2] https://ci.trafficserver.apache.org/files/BuildMachines/CentOS6

Additionally the plan going forward for this is to remove all the parsing from TSConfig and have it depend on Lua.

Nice!

[zwoop]

Lets re-run this with the new Github builders: [approve ci]

[zwoop]

Note that it has to succeed on CentOS6, which is indeed running

[root@centos6 ~]# bison  --version
bison (GNU Bison) 2.4.1

[PSUdaemon]

@jablko can you rebase this?

[bryancall]

[approve ci]

[zwoop]

Still feels like we have to support the Bison that comes with CentOS6.

[bryancall]

Ran a build on this for Centos 6 to see if there is an issue.

[zwoop]

Part of the "trickiness" here is that the file is also checked into git, so many cases, we don't need bison at all. But it doesn't seem to be particularly deterministic.

[bryancall]

There hasn't been an update on this PR for over 60 days, so I am closing it for now. Feel free to reopen the PR when you have updated it.