Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit std:: name space, seems to make compiler happy #1574

Merged
merged 1 commit into from Mar 14, 2017
Merged

Explicit std:: name space, seems to make compiler happy #1574

merged 1 commit into from Mar 14, 2017

Conversation

zwoop
Copy link
Contributor

@zwoop zwoop commented Mar 13, 2017

This hopefully fixes the build errors on isnan() usage on the
Ubuntu 16 platform, and also makes it clear which isnan() we use
here.

@zwoop zwoop added the Manager label Mar 13, 2017
@zwoop zwoop added this to the 7.2.0 milestone Mar 13, 2017
@zwoop zwoop self-assigned this Mar 13, 2017
@atsci
Copy link

atsci commented Mar 13, 2017

clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/45/

@atsci
Copy link

atsci commented Mar 13, 2017

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/58/

@atsci
Copy link

atsci commented Mar 13, 2017

AU check failed! https://ci.trafficserver.apache.org/job/autest-github/42/

@atsci
Copy link

atsci commented Mar 13, 2017

FreeBSD11 build failed! https://ci.trafficserver.apache.org/job/freebsd-github/1740/

@atsci
Copy link

atsci commented Mar 13, 2017

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1634/

@atsci
Copy link

atsci commented Mar 13, 2017

Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/169/

@atsci
Copy link

atsci commented Mar 13, 2017

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/301/

@atsci
Copy link

atsci commented Mar 14, 2017

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/60/

@atsci
Copy link

atsci commented Mar 14, 2017

clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/47/

@atsci
Copy link

atsci commented Mar 14, 2017

AU check failed! https://ci.trafficserver.apache.org/job/autest-github/44/

@atsci
Copy link

atsci commented Mar 14, 2017

FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/1742/

@atsci
Copy link

atsci commented Mar 14, 2017

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1636/

@atsci
Copy link

atsci commented Mar 14, 2017

Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/172/

@atsci
Copy link

atsci commented Mar 14, 2017

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/304/

@zwoop
Explicit std:: name space, seems to make compiler happy
af6730a 
This also cleans up the mess around math.h vs cmath on the includes,
this was necessary to make all platforms and compilers happy.
@atsci
Copy link

atsci commented Mar 14, 2017

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/64/

@atsci
Copy link

atsci commented Mar 14, 2017

clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/51/

@atsci
Copy link

atsci commented Mar 14, 2017

AU check failed! https://ci.trafficserver.apache.org/job/autest-github/48/

@atsci
Copy link

atsci commented Mar 14, 2017

Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/177/

@atsci
Copy link

atsci commented Mar 14, 2017

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1640/

@atsci
Copy link

atsci commented Mar 14, 2017

FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/1746/

@SolidWallOfCode
Copy link
Member

SolidWallOfCode commented Mar 14, 2017 •
edited

Ship it.

@zwoop
Copy link
Contributor Author

zwoop commented Mar 14, 2017

Yeh, we want to remove the check for math.h, and the patch does. No?

@atsci
Copy link

atsci commented Mar 14, 2017

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/309/

@zwoop zwoop merged commit b91176d into apache:master Mar 14, 2017
@zwoop zwoop deleted the ISNAN branch March 14, 2017 17:06
@zwoop zwoop modified the milestones: 7.2.0, 8.0.0 Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SolidWallOfCode SolidWallOfCode SolidWallOfCode approved these changes

Assignees

@zwoop zwoop

Labels
Manager
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zwoop @atsci @SolidWallOfCode