Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS-4976: Regularize plugins - protocol #1601

Merged
merged 1 commit into from Mar 24, 2017

Conversation

SolidWallOfCode
Copy link
Member

Incremental work on #1114.

This also updates the documentation on building a protocol plugin. In addition to changes required by the standardization of the plugin code, other errors were correct. Literal references were converted to links as much as possible.

@atsci
Copy link

atsci commented Mar 23, 2017

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/105/

@atsci
Copy link

atsci commented Mar 23, 2017

@atsci
Copy link

atsci commented Mar 23, 2017

@atsci
Copy link

atsci commented Mar 23, 2017

FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/1787/

@atsci
Copy link

atsci commented Mar 23, 2017

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1680/

@atsci
Copy link

atsci commented Mar 23, 2017

Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/218/

@atsci
Copy link

atsci commented Mar 23, 2017

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/350/

@@ -122,33 +122,29 @@ TSPluginInit(int argc, const char *argv[])
server_port = 4666;

if (argc < 3) {
TSDebug("protocol", "Usage: protocol.so accept_port server_port");
TSDebug(PLUGIN_NAME, "Usage: protocol.so accept_port server_port");
printf("[protocol_plugin] Usage: protocol.so accept_port server_port\n");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep these two?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not, I must have missed that one.

@SolidWallOfCode
Copy link
Member Author

SolidWallOfCode commented Mar 23, 2017

@maskit 's comment reminds me that I also removed a number of printf statements which seemed to duplicate the debug output.

@atsci
Copy link

atsci commented Mar 23, 2017

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/108/

@atsci
Copy link

atsci commented Mar 23, 2017

@atsci
Copy link

atsci commented Mar 23, 2017

@atsci
Copy link

atsci commented Mar 23, 2017

FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/1790/

@atsci
Copy link

atsci commented Mar 23, 2017

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1683/

@atsci
Copy link

atsci commented Mar 23, 2017

Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/221/

@atsci
Copy link

atsci commented Mar 23, 2017

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/353/

Copy link
Member

@maskit maskit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SolidWallOfCode SolidWallOfCode merged commit 6abe654 into apache:master Mar 24, 2017
@zwoop zwoop modified the milestones: 7.2.0, 8.0.0 Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants