New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TS-4976: Regularize plugins - protocol #1601
TS-4976: Regularize plugins - protocol #1601
Conversation
RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/105/ |
clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/92/ |
AU check successful! https://ci.trafficserver.apache.org/job/autest-github/89/ |
FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/1787/ |
Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1680/ |
Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/218/ |
clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/350/ |
example/protocol/Protocol.c
Outdated
@@ -122,33 +122,29 @@ TSPluginInit(int argc, const char *argv[]) | |||
server_port = 4666; | |||
|
|||
if (argc < 3) { | |||
TSDebug("protocol", "Usage: protocol.so accept_port server_port"); | |||
TSDebug(PLUGIN_NAME, "Usage: protocol.so accept_port server_port"); | |||
printf("[protocol_plugin] Usage: protocol.so accept_port server_port\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep these two?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not, I must have missed that one.
@maskit 's comment reminds me that I also removed a number of |
c759ec8
to
360a596
Compare
RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/108/ |
clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/95/ |
AU check successful! https://ci.trafficserver.apache.org/job/autest-github/92/ |
FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/1790/ |
Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1683/ |
Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/221/ |
clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/353/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Incremental work on #1114.
This also updates the documentation on building a protocol plugin. In addition to changes required by the standardization of the plugin code, other errors were correct. Literal references were converted to links as much as possible.