Fix string compare for protocol tag logic in UnixNetVConnection. #1616
Conversation
|
RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/128/ |
|
clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/114/ |
|
AU check successful! https://ci.trafficserver.apache.org/job/autest-github/111/ |
|
Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/240/ |
|
FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/1810/ |
|
Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1701/ |
|
Dang, that's not going to work either. Because it's a prefix it's not wrong if the incoming tag is shorter than the internal tag. |
|
clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/372/ |
SolidWallOfCode
force-pushed
the
i-agree-with-phil-7
branch
from
50c7bec
to
e9faf30
Compare
|
clang format failed! https://ci.trafficserver.apache.org/job/clang-format-github/115/ |
|
RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/129/ |
|
AU check successful! https://ci.trafficserver.apache.org/job/autest-github/112/ |
|
Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/241/ |
|
Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1702/ |
|
FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/1811/ |
|
RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/130/ |
|
clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/116/ |
|
clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/373/ |
|
AU check successful! https://ci.trafficserver.apache.org/job/autest-github/113/ |
|
Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/242/ |
|
Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1703/ |
|
FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/1812/ |
|
clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/374/ |
SolidWallOfCode
force-pushed
the
i-agree-with-phil-7
branch
from
6da6cf5
to
222d523
Compare
|
clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/143/ |
|
RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/158/ |
|
AU check successful! https://ci.trafficserver.apache.org/job/autest-github/141/ |
|
Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1730/ |
|
FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/1839/ |
|
Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/269/ |
|
clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/401/ |
Switch to using the
StringViewbasedstrcmpwhich handles length issues. The current code is a bit weak on that (it assumes the incomingtagis never longer). Make the implementation not inline, it's a bit big for that.