Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The result of TSHttpTxnParentProxySet() maybe overwrite in ParentConfigParams::findParent() #1617

Merged
merged 1 commit into from
Apr 20, 2017
Merged

The result of TSHttpTxnParentProxySet() maybe overwrite in ParentConfigParams::findParent() #1617

merged 1 commit into from
Apr 20, 2017

Conversation

oknet
Copy link
Member

@oknet oknet commented Mar 29, 2017 •
edited

The code next to apiParentExists(rdata)

  tablePtr->Match(rdata, result);

The result maybe overwrite if the rdata matched with tablePtr.

I could not found a document to describe the TSHttpTxnParentProxySet() in detail.
In my opinion the TSHttpTxnParentProxySet() is the highest priority.

@oknet oknet requested review from zwoop and jrushford March 29, 2017 09:43
@oknet oknet self-assigned this Mar 29, 2017
@oknet oknet modified the milestones: 7.1.1, 7.2.0 Mar 29, 2017
@atsci
Copy link

atsci commented Mar 29, 2017

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/131/

@atsci
Copy link

atsci commented Mar 29, 2017

clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/117/

@atsci
Copy link

atsci commented Mar 29, 2017

AU check successful! https://ci.trafficserver.apache.org/job/autest-github/114/

@atsci
Copy link

atsci commented Mar 29, 2017

FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/1813/

@atsci
Copy link

atsci commented Mar 29, 2017

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1704/

@atsci
Copy link

atsci commented Mar 29, 2017

Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/243/

@atsci
Copy link

atsci commented Mar 29, 2017

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/375/

zwoop
zwoop approved these changes Apr 20, 2017
View reviewed changes
Copy link
Contributor

@zwoop zwoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely seems right to me. It'd be good to get @jrushford 's input too though.

Also, if we agree this is correct, I think this might be a 7.1.x candidate as well.

@jrushford
Copy link
Contributor

it's definitely is right. I approve.

@jrushford jrushford merged commit 3a21205 into apache:master Apr 20, 2017
@zwoop zwoop modified the milestones: 7.1.0, 7.2.0 Apr 22, 2017
@zwoop zwoop added this to 7.1.x backports in 7.x releases Apr 22, 2017
@zwoop
Copy link
Contributor

zwoop commented Apr 22, 2017

This has been back ported to 7.1.x as well.

@zwoop zwoop removed this from 7.1.x backports in 7.x releases Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwoop zwoop zwoop approved these changes

@jrushford jrushford jrushford approved these changes

Assignees

@oknet oknet

Labels
Parent Proxy
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oknet @atsci @jrushford @zwoop