New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a new condition, %{IP:<part>} #1620
Conversation
This replaces the old %{CLIENT-IP}, and generalizes the access to all four IP addresses. E.g. cond %{SEND_RESPONSE_HDR_HOOK} set-header X-Client-IP %{IP:CLIENT} set-header X-Inbound-IP %{IP:INBOUND} set-header X-Server-IP %{IP:SERVER} set-header X-Outbound-IP %{IP:OUTBOUND} In the case of a sockaddr not being populated, e.g. IP:SERVER on a cache hit, the string is "" (empty).
RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/135/ |
clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/121/ |
AU check successful! https://ci.trafficserver.apache.org/job/autest-github/118/ |
FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/1817/ |
Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1708/ |
Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/247/ |
clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/379/ |
|
||
cond %{IP:<part>} <operand> | ||
|
||
This is one of four possible IPs associated with the transaction, with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"IP" is "intellectual propety". I think you mean "IP addresses".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
You can commit it, but I'm going to modify the documents to use the correct term "IP address" instead of just "IP" which, sir, is wrong. |
This replaces the old %{CLIENT-IP}, and generalizes the access to
all four IP addresses. E.g.
cond %{SEND_RESPONSE_HDR_HOOK}
set-header X-Client-IP %{IP:CLIENT}
set-header X-Inbound-IP %{IP:INBOUND}
set-header X-Server-IP %{IP:SERVER}
set-header X-Outbound-IP %{IP:OUTBOUND}
In the case of a sockaddr not being populated, e.g. IP:SERVER on
a cache hit, the string is "" (empty).