Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS-3978: Allow empty document caching to follow normal logic #310

Closed
wants to merge 1 commit into from
Closed

TS-3978: Allow empty document caching to follow normal logic #310

wants to merge 1 commit into from

Conversation

unixwitch
Copy link
Contributor

No description provided.

@sudheerv
Copy link
Contributor

Hmm..the requirement in the jira certainly seems reasonable, but, the current state of this is mainly to ensure ATS is not caching broken responses (connection failure in the middle of download).

Allowing to cache the empty docs only when Content-Length=0 indirectly ensures that the response was not broken. So, the patch must somehow ensure that the response is not broken, otherwise, there's a danger of caching invalid responses.

@zwoop zwoop added the Cache label May 13, 2016
@zwoop zwoop added this to the 7.0.0 milestone May 13, 2016
@zwoop
Copy link
Contributor

zwoop commented May 13, 2016

I'm not sure that we're comfortable with this change, since it's been known to cause problems with empty docs in other areas (e.g. clustering). We'll have to take a close look at this, and decide if we should get this in for 7.0.0.

Also, the branch has now diverged, can you please rebase against current master?

@zwoop
Copy link
Contributor

zwoop commented Jul 20, 2016

I'm going to close this for now, please open a new PR after we discuss this more?

@zwoop zwoop closed this Jul 20, 2016
@zwoop zwoop modified the milestone: 7.0.0 May 4, 2017
bneradt pushed a commit to bneradt/trafficserver that referenced this pull request Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants