Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mysql_remap plugin build with MySQL 8 #4360

Merged
merged 1 commit into from
Oct 6, 2018
Merged

Fix mysql_remap plugin build with MySQL 8 #4360

merged 1 commit into from
Oct 6, 2018

Conversation

jbfavre
Copy link
Contributor

@jbfavre jbfavre commented Oct 6, 2018

Starting MySQL 8.0.1 release, the my_bool type has been removed, leading mysql_remap build to fail.
Details in https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-1.html#mysqld-8-0-1-compiling state that my_bool should be replaced with C type bool.
Although not yet tested with MySQL 8, this changes is backwards-compatible with older versions of MySQL and MariaDB.

@shukitchan
Copy link
Contributor

[approve ci]

@shukitchan shukitchan self-requested a review October 6, 2018 16:50
@shukitchan shukitchan self-assigned this Oct 6, 2018
@shukitchan shukitchan added this to the 9.0.0 milestone Oct 6, 2018
shukitchan
shukitchan approved these changes Oct 6, 2018
View reviewed changes
Copy link
Contributor

@shukitchan shukitchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thanks.

@shukitchan shukitchan merged commit 05b3052 into apache:master Oct 6, 2018
@jbfavre jbfavre deleted the fix-mysql_remap-plugin-mysql8 branch October 18, 2018 12:45
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Feb 18, 2020
Fix build issue with MySQL 8
7d38dac 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Mar 8, 2020
Fix build issue with MySQL 8
67b4e9b 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Apr 24, 2020
Fix build issue with MySQL 8
0be000f 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request May 7, 2020
Fix build issue with MySQL 8
f5315a7 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Jun 28, 2020
Fix build issue with MySQL 8
2346bc2 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Jul 2, 2020
Fix build issue with MySQL 8
931c259 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Aug 12, 2020
Fix build issue with MySQL 8
4d482d0 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Oct 17, 2020
Fix build issue with MySQL 8
3a37ea1 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Nov 30, 2020
Fix build issue with MySQL 8
f9f2935 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Dec 9, 2020
Fix build issue with MySQL 8
806281e 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Dec 12, 2020
Fix build issue with MySQL 8
8afd62e 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Aug 20, 2021
@muehlenhoff
Fix build issue with MySQL 8
05cf41e 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Aug 20, 2021
@carnil
Fix build issue with MySQL 8
98a225f 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Jun 9, 2022
Fix build issue with MySQL 8
451b413 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Jun 9, 2022
Fix build issue with MySQL 8
88fb7b7 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Aug 13, 2022
Fix build issue with MySQL 8
9c2d0dd 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Jan 10, 2023
Fix build issue with MySQL 8
ff8a5a7 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Jan 22, 2023
Fix build issue with MySQL 8
f44a97e 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request May 11, 2023
Fix build issue with MySQL 8
d6cfe6a 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Jul 27, 2023
@AdrianBunk
Fix build issue with MySQL 8
00ef96f 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Jul 27, 2023
Fix build issue with MySQL 8
b020f80 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Oct 2, 2023
@AdrianBunk
Fix build issue with MySQL 8
0d6c0ce 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Nov 9, 2023
@AdrianBunk
Fix build issue with MySQL 8
1548980 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Nov 9, 2023
Fix build issue with MySQL 8
b9ba8d6 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request May 25, 2024
@AdrianBunk
Fix build issue with MySQL 8
85a8eb7 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request May 25, 2024
Fix build issue with MySQL 8
8370b18 
Origin: other, https://bugs.launchpad.net/ubuntu/+source/trafficserver/+bug/1795362
Forwarded: apache/trafficserver#4360
Applied-Upstream: apache/trafficserver@05b3052
Reviewed-by: Jean Baptiste Favre <debian@jbfavre.org>
Last-Update: 2018-10-06

The my_bool type is no longer used in MySQL source code.
Any third-party code that used this type to represent C
boolean variables should use the bool or int C type instead.
Last-Update: 2018-10-06
Gbp-Pq: Name 0009-fix-mysql-8-build.patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shukitchan shukitchan shukitchan approved these changes

Assignees

@shukitchan shukitchan

Labels
Plugins
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbfavre @shukitchan