Fix spelling errors reported by lintian #4750

jbfavre · 2019-01-04T09:22:01Z

While packaging trafficserver for Debian, lintian reported spelling errors which I decided to fix.

scw00 · 2019-01-04T09:27:44Z

Please squash PRs.

jbfavre · 2019-01-04T09:36:43Z

done !

scw00 · 2019-01-04T09:48:17Z

thanks

scw00 · 2019-01-04T10:06:29Z

You may need to run “make clang-format” to make clang-format check happy.

jbfavre · 2019-01-04T11:10:11Z

Didn't knew (or forgot) about clang-format.
I've updated the PR.
Should be good now

scw00

thanks

Forwarded: apache/trafficserver#4750 Applied-Upstream: apache/trafficserver@af0ad4a Last-Update: 2019-01-03 Last-Update: 2019-01-03 Gbp-Pq: Name 0012-fix-spelling-checks.patch

List of included PRs: - apache#6363 (partial pick) - apache#6420 - apache#6419 - apache#6354 - apache#6252 - apache#4513 - apache#4603 - apache#4750 (partial pick) - apache#4604 - apache#4540 - apache#4777 - apache#4862 - apache#4814 - apache#4802 - apache#4897 - apache#4988 - apache#5034 - apache#5140 - apache#5112 - apache#4895 - apache#5834 (partial pick) - apache#6061 - apache#6210 (partial pick) - apache#6265 (partial pick) - apache#6282 (partial pick) Updating uri_signing docs to reflect new RFC changes (cherry picked from commit 90e51a2) Add normalization the URI before cdniuc validation (cherry picked from commit b39b0f7) JWT Parser strips token from URI and places in buffer (cherry picked from commit 5f9d358) Use POSIX ERE for uri signing regex evaluation (cherry picked from commit be56b3a) Implement nbf claim in Uri Signing Plugin (cherry picked from commit d9dc0f4) Implement aud claim in Uri Signing Plugin The Aud claim is implemented as per the RFC version 16 that can be found here:https://tools.ietf.org/html/draft-ietf-cdni-uri-signing-16 As per the specification, the aud claim can be either a JSON array or a string. The aud claim is stored as raw json in the jwt class in this implementation. It is converted either to an array or a string at validation time. This commit also expands the unit tests quite a bit. Test configs can be provided in the unit_tests directory and parsed in the test framework. JWS validation is also testable now. This commit also fixes two memory leaks 1. Issuers were never being freed on configuration cleanup. 2. Token renewal allocates a tmp json_object without freeing. (cherry picked from commit 012d437) cdniuc is not a manditory claim With Internet Draft 16 for uri signing, the cdniuc claim is not manditory. It took the place of the manditory sub claim in draft 12, and the manditory nature of the sub claim was still in effect. This change allows for tokens to not contain the cdniuc claim and also renews the cdniuc and cdnistd claim on token renewal. (cherry picked from commit fa53771) add --with-jansson and --with-cjose options, document sample commands for building and configuring both locally (cherry picked from commit 0cce83c) Strip token from upstream if conifigured and dynamically allocate string buffers Adds a configuration option to strip uri signing tokens from both the cache key URL and the upstream URL. Additionally it was pointed out that some statically allocated buffers were too small in some of the string manipulating functions (normalize and strip token). These buffers are now dynamically allocated since the maximum buffer size is known for these. (cherry picked from commit 192dc83) Cherry-pick from commit 4cfd5a7 Add Example URI Signer Python Script Provide an example script to be used in conjunction with the uri signing plugin. This script is meant to serve as an example of how to get started with uri signing and could be useful in testing various configs. (cherry picked from commit 3632eb7) Cherry-pick from commit 9c1b88a Cherry-pick from commit a139fd1 Cherry-pick from commit c07474d Add simple autest and subsequent fixes (cherry picked from commit ea3aa04) Cherry-pick from commit 6d64842 URI Sig Null Check for Clang Warning (apache#6419) This commit adds a missing null check in the uri normalization function. This was caught by the clang analyzer. (cherry picked from commit 2de1c35) Syntax Error fixed in URI sig Plugin (apache#6420) (cherry picked from commit c154d40) Change gold files to be less restrictive since some of the headers include can be in a different order (apache#6410) (cherry picked from commit 4bdde5d) Add a dummy cachekey usage to handle the effective vs pristine url issue that exists in 8x where the first plugin gets a different url then subsequent ones. This is not needed on 9x+

List of included PRs: - #6363 (partial pick) - #6420 - #6419 - #6354 - #6252 - #4513 - #4603 - #4750 (partial pick) - #4604 - #4540 - #4777 - #4862 - #4814 - #4802 - #4897 - #4988 - #5034 - #5140 - #5112 - #4895 - #5834 (partial pick) - #6061 - #6210 (partial pick) - #6265 (partial pick) - #6282 (partial pick) Updating uri_signing docs to reflect new RFC changes (cherry picked from commit 90e51a2) Add normalization the URI before cdniuc validation (cherry picked from commit b39b0f7) JWT Parser strips token from URI and places in buffer (cherry picked from commit 5f9d358) Use POSIX ERE for uri signing regex evaluation (cherry picked from commit be56b3a) Implement nbf claim in Uri Signing Plugin (cherry picked from commit d9dc0f4) Implement aud claim in Uri Signing Plugin The Aud claim is implemented as per the RFC version 16 that can be found here:https://tools.ietf.org/html/draft-ietf-cdni-uri-signing-16 As per the specification, the aud claim can be either a JSON array or a string. The aud claim is stored as raw json in the jwt class in this implementation. It is converted either to an array or a string at validation time. This commit also expands the unit tests quite a bit. Test configs can be provided in the unit_tests directory and parsed in the test framework. JWS validation is also testable now. This commit also fixes two memory leaks 1. Issuers were never being freed on configuration cleanup. 2. Token renewal allocates a tmp json_object without freeing. (cherry picked from commit 012d437) cdniuc is not a manditory claim With Internet Draft 16 for uri signing, the cdniuc claim is not manditory. It took the place of the manditory sub claim in draft 12, and the manditory nature of the sub claim was still in effect. This change allows for tokens to not contain the cdniuc claim and also renews the cdniuc and cdnistd claim on token renewal. (cherry picked from commit fa53771) add --with-jansson and --with-cjose options, document sample commands for building and configuring both locally (cherry picked from commit 0cce83c) Strip token from upstream if conifigured and dynamically allocate string buffers Adds a configuration option to strip uri signing tokens from both the cache key URL and the upstream URL. Additionally it was pointed out that some statically allocated buffers were too small in some of the string manipulating functions (normalize and strip token). These buffers are now dynamically allocated since the maximum buffer size is known for these. (cherry picked from commit 192dc83) Cherry-pick from commit 4cfd5a7 Add Example URI Signer Python Script Provide an example script to be used in conjunction with the uri signing plugin. This script is meant to serve as an example of how to get started with uri signing and could be useful in testing various configs. (cherry picked from commit 3632eb7) Cherry-pick from commit 9c1b88a Cherry-pick from commit a139fd1 Cherry-pick from commit c07474d Add simple autest and subsequent fixes (cherry picked from commit ea3aa04) Cherry-pick from commit 6d64842 URI Sig Null Check for Clang Warning (#6419) This commit adds a missing null check in the uri normalization function. This was caught by the clang analyzer. (cherry picked from commit 2de1c35) Syntax Error fixed in URI sig Plugin (#6420) (cherry picked from commit c154d40) Change gold files to be less restrictive since some of the headers include can be in a different order (#6410) (cherry picked from commit 4bdde5d) Add a dummy cachekey usage to handle the effective vs pristine url issue that exists in 8x where the first plugin gets a different url then subsequent ones. This is not needed on 9x+

Forwarded: apache/trafficserver#4750 Applied-Upstream: apache/trafficserver@af0ad4a Last-Update: 2019-01-03 Last-Update: 2019-01-03 Gbp-Pq: Name 0012-fix-spelling-checks.patch

scw00 assigned jbfavre Jan 4, 2019

scw00 added Cleanup Documentation labels Jan 4, 2019

scw00 added this to the 9.0.0 milestone Jan 4, 2019

jbfavre force-pushed the spelling_fixes branch from 28a0509 to 7cb32b0 Compare January 4, 2019 09:35

Fix spelling errors reported by lintian

051d022

jbfavre force-pushed the spelling_fixes branch from 7cb32b0 to 051d022 Compare January 4, 2019 10:54

scw00 changed the title ~~Spelling fixes~~ Fix spelling errors reported by lintian Jan 4, 2019

scw00 approved these changes Jan 4, 2019

View reviewed changes

scw00 merged commit af0ad4a into apache:master Jan 5, 2019

jbfavre deleted the spelling_fixes branch January 7, 2019 09:36

zwoop modified the milestones: 9.0.0, Docs Oct 30, 2019

ezelkow1 mentioned this pull request Apr 6, 2020

Backport of all uri signing commits from master to 8.1.x #6584

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix spelling errors reported by lintian #4750

Fix spelling errors reported by lintian #4750

jbfavre commented Jan 4, 2019

scw00 commented Jan 4, 2019

jbfavre commented Jan 4, 2019

scw00 commented Jan 4, 2019

scw00 commented Jan 4, 2019

jbfavre commented Jan 4, 2019

scw00 left a comment

Fix spelling errors reported by lintian #4750

Fix spelling errors reported by lintian #4750

Conversation

jbfavre commented Jan 4, 2019

scw00 commented Jan 4, 2019

jbfavre commented Jan 4, 2019

scw00 commented Jan 4, 2019

scw00 commented Jan 4, 2019

jbfavre commented Jan 4, 2019

scw00 left a comment

Choose a reason for hiding this comment