TS-4291 Adds log field "pqnhl" which ignores internal headers.

[ogoodman]

This should be a very safe fix in that it only adds a new log field and does not change the behaviour of any existing functions. An alternative would be to not add a new log field, but simply change the behaviour of the existing "pqhl" field.

[jpeach]

This should be HTTPHdr::net_length_get() const.

[zwoop]

At a minimum, we need a rebase of this before proceeding. This can't really be 100+ commits :).

[ogoodman]

Yeah, I'm not sure what happened there. I thought I was rebasing it and that was what somehow caused all those commits to show up. I will see if I can do something about it.

What I need to know though, is whether you really want this new field or would prefer to fix the value of pqhl?

Looking at the documentation made me think that adding a new field would just make an obscure mess and the odds of anyone relying critically on the existing behaviour seem very low.

[zwoop]

So, now that we're on the 7.0.0 release cycle, I wonder if we should have pqhl, cqhl, pshl, and sshl all exclude any @ headers? If not, if we really want this, don't we also want all 4 variants of these tags for consistency? I.e. pqhnl, cqhln, pshln, and sshln ?

@jpeach Wdyt? I'm leaning more towards a 7.0.0 incompatible change and exclude any @ headers from these calculations, but maybe that's just a too expensive change to make (computational expensive).

[jpeach]

@zwoop @ogoodman I agree that the logging tags should ignore any headers not send on the wire. Let's fix the existing tags rather than make new ones. I would say the current behavior is just a bug.

[bryancall]

@ogoodman
We talked about this in the github PR meeting and would like to remove logging of the @ headers for the current tags.

[ogoodman]

Hi Bryan, Sorry, I probably should have let you know sooner. Please feel free to close any pull requests of mine. I have changed jobs and no longer work with Traffic Server. Much as I'd like to contribute I don't really have the spare time to do so in any meaningful way. Regards to yourself and the rest of the team,

…

-Oliver

On 17/12/16 03:57, Bryan Call wrote: @ogoodman <https://github.com/ogoodman> We talked about this in the github PR meeting and would like to remove logging of the @ headers for the current tags. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#588 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFNB3d4VRFl6gSsPGBft9jOgubsPTUwPks5rIsLngaJpZM4ILQqN>.