Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling HTTP/2 priority frames limit #5888

Merged
merged 1 commit into from Sep 3, 2019
Merged

Allow disabling HTTP/2 priority frames limit #5888

merged 1 commit into from Sep 3, 2019

Conversation

jvgutierrez
Copy link
Member

As discussed yesterday on Slack, there are some scenarios, specially when proxy.config.http2.stream_priority_enabled is set to 0 where disabling HTTP/2 priority frames limit is interesting. This PR allows to disable it by setting proxy.config.http2.max_priority_frames_per_minute to 0

@maskit maskit added the HTTP/2 label Aug 28, 2019
@maskit maskit added this to the 10.0.0 milestone Aug 28, 2019
@maskit maskit added this to In progress in 9.0.x Branch and Release via automation Aug 28, 2019
sudheerv
sudheerv reviewed Aug 28, 2019
View reviewed changes
Copy link
Contributor

@sudheerv sudheerv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency and completeness, I think we should've similar disable mechanism for rate limiting the Settings, Ping, Error Rate as well.

@bryancall
Copy link
Contributor

[approve ci autest]

bryancall
bryancall previously approved these changes Aug 28, 2019
View reviewed changes
9.0.x Branch and Release automation moved this from In progress to Ready to Merge Aug 28, 2019
@zwoop
Copy link
Contributor

zwoop commented Aug 28, 2019

@jvgutierrez Would you mind making similar changes for the other rate limiting settings ? If not, I'm ok landing this, and make a separate PR.

@zwoop
Copy link
Contributor

zwoop commented Aug 28, 2019

Also, it feels that if proxy.config.http2.stream_priority_enabled == 0, we ought to ignore the frames rather than rate limiting them ?

@jvgutierrez jvgutierrez force-pushed the allow-disabling-h2-priority-limit branch from e9d7b1e to be88436 Compare August 29, 2019 02:15
9.0.x Branch and Release automation moved this from Ready to Merge to For Review Aug 29, 2019
@jvgutierrez
Copy link
Member Author

Also, it feels that if proxy.config.http2.stream_priority_enabled == 0, we ought to ignore the frames rather than rate limiting them ?

PR updated, now the limit is only enforced if proxy.config.http2.stream_priority_enabled is set to 1, otherwise the frames are just ignored.

@jvgutierrez jvgutierrez force-pushed the allow-disabling-h2-priority-limit branch from be88436 to c798c39 Compare August 29, 2019 04:16
9.0.x Branch and Release automation moved this from For Review to Ready to Merge Sep 3, 2019
shinrich
shinrich previously approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@shinrich shinrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Unfortunately, the PR needs to be rebased due to other merges causing conflicts.

@jvgutierrez jvgutierrez force-pushed the allow-disabling-h2-priority-limit branch from c798c39 to cd4582c Compare September 3, 2019 14:54
9.0.x Branch and Release automation moved this from Ready to Merge to For Review Sep 3, 2019
@jvgutierrez
Copy link
Member Author

Looks good to me. Unfortunately, the PR needs to be rebased due to other merges causing conflicts.

done!

9.0.x Branch and Release automation moved this from For Review to Ready to Merge Sep 3, 2019
@maskit maskit merged commit f2ebbce into apache:master Sep 3, 2019
9.0.x Branch and Release automation moved this from Ready to Merge to Cherry Pick Sep 3, 2019
@zwoop
Copy link
Contributor

zwoop commented Oct 1, 2019

Cherry-picked to v9.0.x branch.

@zwoop zwoop removed this from Cherry Pick in 9.0.x Branch and Release Oct 1, 2019
@zwoop zwoop removed this from the 10.0.0 milestone Oct 1, 2019
@zwoop zwoop added this to the 9.0.0 milestone Oct 1, 2019
@masaori335 masaori335 added this to H2 Backports for 8.0.7 or 8.1.0 in 8.x releases Feb 12, 2020
@masaori335 masaori335 mentioned this pull request Mar 27, 2020
Merged
@zwoop zwoop removed this from H2 Backports for 8.1.0 in 8.x releases Mar 30, 2020
@zwoop zwoop modified the milestones: 9.0.0, 8.1.0 Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudheerv sudheerv sudheerv left review comments

@maskit maskit maskit approved these changes

@bryancall bryancall bryancall left review comments

@shinrich shinrich shinrich left review comments

Assignees

@jvgutierrez jvgutierrez

Labels
HTTP/2
Projects
None yet
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jvgutierrez @bryancall @zwoop @maskit @shinrich @sudheerv