TS-4497: fix fetch api to release async item sooner #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shukitchan : is the "deleted" state protecting against multiple threads calling the cleanup? If so, it may still not be enough, without a mutex of some sort? |
|
The added call to ts_lua_fetch_multi_cleanup() is protected with a mutex. |
|
@sudheerv I made the change already. Please take a look. |
|
👍 |
JosiahWI
pushed a commit
to JosiahWI/trafficserver
that referenced
this pull request
Jul 19, 2023
apache#685) A proper fix will require a lot of restructuring of the SSLSecret code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sudheerv this is what we have been discussing for a while. With TS-3777, the ts.fetch() of ts_lua is no longer working fine. I finally figure out that the original plugin code committed is not performing cleanup correctly.
Thanks. please take a look.