TS-3245: Fixed reset of getopt_long() global variables between plugin initialization calls to allow #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pbchou
commented
Jun 7, 2016
pbchou
commented
multiple global plugins to co-exist in the plugin.config file.
Also, made the same changes to allow remap plugins to co-exist
with each other in the remap.config file.
Specifically, on freebsd and darwin platforms we use
'optreset = 1' to reset the getopt_long() command line parser.
On Linux/glibc we use 'optind = 0' to reset the parser.
The parser must be reset between uses such as first loading
one plugin and then another.
The setting of these variables is now performed in ATS core
before the plugin initialization functions are called. The
setting of these variables inside of the individual plugins
has been removed. If a plugin needs to call getopt_long()
outside of the plugin global or remap intializations,
it should use the code in proxy/Plugin.cc as an example.
|
Can we change the Subject line of this to describe what this fixes? |
pbchou
changed the title
pbchou
changed the title
|
[approve ci] |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/74/ for details. |
ogoodman
pushed a commit
to ogoodman/trafficserver
that referenced
this pull request
Aug 20, 2016
Allow multiple global plugins to co-exist in the plugin.config file. Also, made the same changes to allow remap plugins to co-exist with each other in the remap.config file. Specifically, on freebsd and darwin platforms we use 'optreset = 1' to reset the getopt_long() command line parser. On Linux/glibc we use 'optind = 0' to reset the parser. The parser must be reset between uses such as first loading one plugin and then another. The setting of these variables is now performed in ATS core before the plugin initialization functions are called. The setting of these variables inside of the individual plugins has been removed. If a plugin needs to call getopt_long() outside of the plugin global or remap intializations, it should use the code in proxy/Plugin.cc as an example. This closes apache#696.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.