Remove incorrect assert in inactivity timeout handling

[sudheerv]

Also fix duplicate decrement of current client connection metric

(gdb) bt
#0  0x00002b47d71c8207 in raise () from /lib64/libc.so.6
#1  0x00002b47d71c98f8 in abort () from /lib64/libc.so.6
#2  0x00002b47d488835b in ink_abort (message_format=message_format@entry=0x2b47d49052a7 "%s:%d: failed assertion `%s`") at ink_error.cc:99
#3  0x00002b47d4885045 in _ink_assert (expression=expression@entry=0x7df070 "read_state != HCS_ACTIVE_READER && read_state != HCS_INIT", file=file@entry=0x7ded58 "Http1ClientSession.cc", line=line@entry=91) at ink_assert.cc:37
#4  0x0000000000524111 in Http1ClientSession::release_transaction (this=<optimized out>) at Http1ClientSession.cc:91
#5  0x0000000000551b0d in HttpSM::kill_this (this=this@entry=0x2b48c2641250) at HttpSM.cc:7094
#6  0x0000000000551fff in HttpSM::main_handler (this=0x2b48c2641250, event=105, data=0x2b4842269120) at HttpSM.cc:2723
#7  0x0000000000776a33 in handleEvent (data=0x2b4842269120, event=105, this=0x2b48c2641250) at /export/content/data/multiproduct-post-commit/i001/workspace/ats-core_0ad445ac42ee7fccdadd49b62b6fe429bb226f02/ats9/src/iocore/eventsystem/I_Continuation.h:190
#8  read_signal_and_update (event=105, vc=0x2b4842268f40) at UnixNetVConnection.cc:83
#9  0x0000000000777db7 in UnixNetVConnection::mainEvent (this=0x2b4842268f40, event=<optimized out>, e=<optimized out>) at UnixNetVConnection.cc:1155
#10 0x00000000007675ad in InactivityCop::check_inactivity (this=0x2b47e04b1040, event=<optimized out>, e=<optimized out>) at UnixNet.cc:93
#11 0x00000000007c5e11 in handleEvent (data=0x2b47d8581aa0, event=2, this=0x2b47e04b1040) at I_Continuation.h:190
#12 EThread::process_event (this=this@entry=0x2b47da220000, e=e@entry=0x2b47d8581aa0, calling_code=2) at UnixEThread.cc:127
#13 0x00000000007c6d24 in EThread::execute_regular (this=this@entry=0x2b47da220000) at UnixEThread.cc:236
#14 0x00000000007c71b2 in EThread::execute (this=0x2b47da220000) at UnixEThread.cc:327
#15 0x00000000007c5559 in spawn_thread_internal (a=0x2b47d8571d80) at Thread.cc:92
#16 0x00002b47d64dedd5 in start_thread () from /lib64/libpthread.so.0
#17 0x00002b47d728fead in clone () from /lib64/libc.so.6

(gdb) f 5
#5  0x0000000000551b0d in HttpSM::kill_this (this=this@entry=0x2b48c2641250) at HttpSM.cc:7094
7094	HttpSM.cc: No such file or directory.
(gdb) p this->ua_txn->_proxy_ssn
$1 = (ProxySession *) 0x2b4835f93330
(gdb) p ((Http1ClientSession*)0x2b4835f93330)->read_state
$2 = Http1ClientSession::HCS_ACTIVE_READER

(gdb) bt
#0  0x00002ac86de48207 in raise () from /lib64/libc.so.6
#1  0x00002ac86de498f8 in abort () from /lib64/libc.so.6
#2  0x00002ac86b50835b in ink_abort (message_format=message_format@entry=0x2ac86b5852a7 "%s:%d: failed assertion `%s`") at ink_error.cc:99
#3  0x00002ac86b505045 in _ink_assert (expression=expression@entry=0x7df070 "read_state != HCS_ACTIVE_READER && read_state != HCS_INIT", file=file@entry=0x7ded58 "Http1ClientSession.cc", line=line@entry=91) at ink_assert.cc:37
#4  0x0000000000524111 in Http1ClientSession::release_transaction (this=<optimized out>) at Http1ClientSession.cc:91
#5  0x0000000000551b0d in HttpSM::kill_this (this=this@entry=0x2ac981e71590) at HttpSM.cc:7094
#6  0x0000000000551fff in HttpSM::main_handler (this=0x2ac981e71590, event=2301, data=0x2ac981e72510) at HttpSM.cc:2723
#7  0x000000000059ede1 in handleEvent (data=0x2ac981e72510, event=2301, this=0x2ac981e71590) at /export/content/data/multiproduct-post-commit/i001/workspace/ats-core_0ad445ac42ee7fccdadd49b62b6fe429bb226f02/ats9/src/iocore/eventsystem/I_Continuation.h:190
#8  HttpTunnel::main_handler (this=0x2ac981e72510, event=<optimized out>, data=<optimized out>) at HttpTunnel.cc:1629
#9  0x0000000000711e83 in handleEvent (data=0x2ac8f41d87d8, event=105, this=0x2ac981e72510) at /export/content/data/multiproduct-post-commit/i001/workspace/ats-core_0ad445ac42ee7fccdadd49b62b6fe429bb226f02/ats9/src/iocore/eventsystem/I_Continuation.h:190
#10 PluginVC::process_timeout (this=this@entry=0x2ac8f41d8608, e=e@entry=0x2ac8f41d88b8, event_to_send=event_to_send@entry=105) at PluginVC.cc:783
#11 0x0000000000717661 in PluginVC::main_handler (this=0x2ac8f41d8608, event=<optimized out>, data=0x2ac8f0d17f60) at PluginVC.cc:210
#12 0x00000000007c5e11 in handleEvent (data=0x2ac8f0d17f60, event=2, this=0x2ac8f41d8608) at I_Continuation.h:190
#13 EThread::process_event (this=this@entry=0x2ac871a20000, e=e@entry=0x2ac8f0d17f60, calling_code=2) at UnixEThread.cc:127
#14 0x00000000007c6d24 in EThread::execute_regular (this=this@entry=0x2ac871a20000) at UnixEThread.cc:236
#15 0x00000000007c71b2 in EThread::execute (this=0x2ac871a20000) at UnixEThread.cc:327
#16 0x00000000007c5559 in spawn_thread_internal (a=0x2ac86f171fc0) at Thread.cc:92
#17 0x00002ac86d15edd5 in start_thread () from /lib64/libpthread.so.0
#18 0x00002ac86df0fead in clone () from /lib64/libc.so.6


(gdb) f 5
#5  0x0000000000551b0d in HttpSM::kill_this (this=this@entry=0x2ac981e71590) at HttpSM.cc:7094
7094	HttpSM.cc: No such file or directory.
(gdb) p this->ua_txn->_proxy_ssn
$1 = (ProxySession *) 0x2ac906437d10
(gdb) p ((Http1ClientSession *)0x2ac906437d10)->read_state
$2 = Http1ClientSession::HCS_ACTIVE_READER
(gdb) p this->history
$3 = {history = {{location = {file = 0x7e889e "HttpSM.cc", func = 0x7e9b10 <HttpSM::do_setup_post_tunnel(HttpVC_t)::__FUNCTION__> "do_setup_post_tunnel", line = 5893}, event = 34463, reentrancy = 1}, {location = {file = 0x7e889e "HttpSM.cc", 
........

        func = 0x7ea1e0 <HttpSM::state_send_server_request_header(int, void*)::__FUNCTION__> "state_send_server_request_header", line = 2023}, event = 103, reentrancy = 1}}, history_pos = 77}

[shinrich]

Looks good. We ran across this as well once in our production so far.

In your crash, I tracked it down to an inactivity timeout on the client side during the post tunnel. For some reason the timeouts were not cleaning up, but the error/eos cases were. I think we want to tidy up there as well. But that can be a different issue. I think this addresses the issue as well.

[zwoop]

Cherry-picked to v9.0.x branch.