-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apple Silicon macOS support #7389
Conversation
41d650b
to
c81bb76
Compare
I am confused that there are changes to catch.hpp but no change to the version, how is that possible? trafficserver/tests/include/catch.hpp Line 2 in a884cc1
|
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I am confused that there are changes to catch.hpp but no change to the version, how is that possible? trafficserver/tests/include/catch.hpp Line 2 in a884cc1
|
I manually back ported the apple-related changes from catch. Upgrading catch to it's latest version is an effort of it's own: #7464 |
@randall Can you have a better explanation of what is happening? We did a code review today and had questions. |
Allows builds on Apple Silicon to complete and run
8eb3d9b
to
0eeee7c
Compare
originally, I back ported some macOS specific changes from catch.hpp's head to get macOS on AS to build. With #7464 merged I no longer need that (and this PR has been fixed up to reflect that) |
Cherry-picked to v9.1.x branch. |
Cherry-picked to v9.0.x branch. |
I think we need to revert this for now, from all release branches. |
Allows builds on Apple Silicon to complete and run