New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TS-4688 handle DNS compression labels in SRV responses #812
Conversation
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/451/ for details. |
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/346/ for details. |
The purpose of this is to use domain name expansion on the name server FQDN? |
Yes, and we actually already do that for seemingly all the other types-- but not for SRV :/ |
srv->port = ink_get16(srv_off + SRV_PORT); | ||
srv->priority = ink_get16(srv_off + SRV_COST); | ||
srv->weight = ink_get16(srv_off + SRV_WEIGHT); | ||
srv->host_len = ::strlen(srv->host) + 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
n
doesn't have the value you want here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly no, n
is the length of the compressed string, not the expanded string-- meaning I have to calculate the len of the expanded string.
* asf/master: (44 commits) TS-4614: avoid e->schedule_in for dummy event. This closes apache#766. Use devtoolset-3 for ATS 7 and later, when available Updated some build instructions TS-4311 Removes support for SPDY completely TS-4683 Adds better error handling on config problems Add TSQA tests for https SRV records TS-4615 set SRV scheme based on next_hop_scheme Add some initial SRV tsqa tests TS-4622 use port from SRV response for origin connections Revert "TS-4622 Use port from SRV response when connecting to origin (apache#773)" TS-4622 Use port from SRV response when connecting to origin (apache#773) TS-4688 handle DNS compression labels in SRV responses (apache#812) cachekey/pattern.h: clang format TS-4667 Uses the WKS in the gzip plugin TS-4653: esi plugin - disable HTTP_COOKIE variable by default and implement a whitelist mechanism to allow the specified cookies for it Original code and idea contributed by Chris Rohlf TS-4680: thread safe initialization in TS*DirGet() functions TS-4652 Fixes log field initialization, previously crippled TS-4595: TSRuntimeDirGet TS-4689 Assert if Machine UUID init fails TS-4674: Remove useless assert statement (apache#809) ...
This will be addressed via Kees's patch: https://github.com/bneradt/trafficserver/pull/3/files
No description provided.