TS-4709: Separate LogFilter expression parsing. #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate LogFilter expression parsing from the configuration file parser so that it can be tested and reused in other contexts.
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/496/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/393/ for details. |
|
👍 |
|
Seems clean, ship it. |
bneradt
pushed a commit
to bneradt/trafficserver
that referenced
this pull request
Feb 6, 2024
the 4th parameter, KeyEqual, is missing in ConnectingIpPool declaration, which may lead to the comparison of two IpEndpoint object won't work as we expected. That is, the default one is unlikely to work with sockaddr type. In another way, IpHelper contains the compare operator for IpEndpoint type, so IpHelper should be used as the KeyEqual parameter of ConnectingIpPoon declaration further discussion could be found in https://ouryahoo.slack.com/archives/C6JQARF25/p1688459341022519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate LogFilter expression parsing from the configuration file
parser so that it can be tested and reused in other contexts.