TS-4794 fix the memory leaks #855
Conversation
[iocore/dns/test_P_DNS.cc:74]: (error) Memory leak: str
[iocore/net/test_P_Net.cc:72]: (error) Memory leak: str
|
[approve ci] |
|
Linux build failed! See https://ci.trafficserver.apache.org/job/Github-Linux/421/ for details. |
|
Needs to run "make clang-format". :) |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/524/ for details. |
[iocore/dns/test_P_DNS.cc:74]: (error) Memory leak: str
[iocore/net/test_P_Net.cc:72]: (error) Memory leak: str
|
Also would have a Jira # in the subject line please. |
|
Greetings @zwoop 😬 Sorry, what is a JIRA number? I've never heard this before. And I know how to change the commit message; is this the same as the subject line? If so, what should I update it to say? 👍 |
|
Ah, so you have to create a Jira ticket (for now at least) in conjunction with the Github PR. Go to https://issues.apache.org/jira/browse/TS/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel and create an account (unless you already did), create a new Issue for the Traffic Server project, and it will give you a TS- number. That's the Jira issue number, and you should refer to it in all commits etc. for this particular issue. |
|
Thank you @zwoop 👍 |
| @@ -68,6 +68,7 @@ struct NetTesterSM : public Continuation { | |||
| default: | |||
| ink_release_assert(!"unknown event"); | |||
| } | |||
| delete[] str; | |||
There was a problem hiding this comment.
str needs to be initialized to NULL.
|
@bryongloden please address James' concern, and we can land this (after we run it on the CI again). |
This closes apache#855.
This closes apache#855.
* Add an HTTP/2 related rate limiting (cherry picked from commit 2706da4) Conflicts: proxy/http2/HTTP2.cc * Updates to work with Yahoo version of 9.1.x Co-authored-by: Masakazu Kitajo <maskit@apache.org>
On line no. 74 of 'test_P_DNS.cc' there is a memory leak and on line no. 72 of 'test_P_Net.cc' there is memory leak -- both memory leaks are errors.
Found by https://github.com/bryongloden/cppcheck