TS-4724: Modified ts_lua plugin to provide ts.server_request.remove_h… #859
Conversation
…ost_name_from_url() method.
|
Kit: Could you please back port the commit on to 6.2.x branch if you are satisfied with the changes? |
|
For new API in InkAPI.cc, please email to dev@ for an API review. Thanks. |
| sdk_assert(sdk_sanity_check_mbuffer(bufp) == TS_SUCCESS); | ||
| sdk_assert(sdk_sanity_check_url_handle(obj) == TS_SUCCESS); | ||
| URL u; | ||
| Debug("cache_url", "[TSUrlRemoveHostName] Removing host name from url"); |
There was a problem hiding this comment.
Why is "cache_url" the right debug tag? It doesn't seem very obvious to me.
There was a problem hiding this comment.
I agree with you. Should I use "http_trans" debug tag? Please suggest.
There was a problem hiding this comment.
I think "http" should be fine.
|
Kit: I don't see any responses to the email I have sent to the dev@ email. What can I do to get the attention of required experts to comment? |
|
I think @jpeach and me replied to your email. Did you not get the response?? Check out here - https://www.mail-archive.com/dev@trafficserver.apache.org/ |
|
oh and you need to subscribe to the dev@ mailing list to get those emails. |
|
In general, this patch is trying to expose the "nuke_proxy_stuff" functionality as an API. And add lua plugin API for that as well.
|
|
Kit: Yes, we can achieve the same functionality using "TSUrlSchemeSet" and "TSUrlHostSet". I will expose these two APIs through ts-lua plugin APIs for "server_request". Should I expose TSUrl*Get() APIs too in ts-lua? Could you please tell me what can I do to the existing pull request? Should I cancel the existing and raise new one? Please help me understand the right procedure. |
|
I think it makes sense. Just make it look similar to "client_request". I think we can close this one. And please change the title on the jira and open a new pull request with the changes on just ts_lua plugin's "server_request" APIs. Thanks a lot. |
|
Closing this PR as suggested by Kit. New PR #906 is submitted. |
There were no conflicts.
TS_LUA and InkAPI.cc are modified to create a new ts_lua API to remove host name from URL in GET request to next-tier.