Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS-4546: Fix a build error on OmniOS #885

Merged
merged 1 commit into from Aug 23, 2016
Merged

TS-4546: Fix a build error on OmniOS #885

merged 1 commit into from Aug 23, 2016

Conversation

maskit
Copy link
Member

@maskit maskit commented Aug 21, 2016

https://issues.apache.org/jira/browse/TS-4546
OmniOS doesn't have d_type in dirent structure, so use stat() instead.

@atsci
Copy link

atsci commented Aug 21, 2016

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/569/ for details.

@atsci
Copy link

atsci commented Aug 21, 2016

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/465/ for details.

@@ -328,8 +328,14 @@ prepare()
cerr << "Cannot open " << input_dir << endl;
return 1;
}
struct stat st;
char name[1024] = "";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

char name[PATH_MAX + 1]

@zwoop zwoop added this to the 7.0.0 milestone Aug 22, 2016
OmniOS doesn't have d_type in dirent structure, so use stat() instead.
@maskit
Copy link
Member Author

maskit commented Aug 22, 2016

Updated.

  • Use PATH_MAX
  • Use ink_strlcat

@atsci
Copy link

atsci commented Aug 22, 2016

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/572/ for details.

@atsci
Copy link

atsci commented Aug 22, 2016

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/468/ for details.

@jpeach
Copy link
Contributor

jpeach commented Aug 22, 2016

👍

@maskit maskit merged commit 48dea10 into apache:master Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants