Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add control char check in MIME Parser #9011

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Conversation

masaori335
Copy link
Contributor

No description provided.

@masaori335 masaori335 added the HTTP label Aug 8, 2022
@masaori335 masaori335 added this to the 10.0.0 milestone Aug 8, 2022
@masaori335 masaori335 self-assigned this Aug 8, 2022
@masaori335 masaori335 added this to In progress in 9.1.x Branch and Release via automation Aug 8, 2022
@masaori335 masaori335 added this to In progress in 9.2.x Branch and Release via automation Aug 8, 2022
@masaori335 masaori335 added this to 8.1.x in 8.x releases Aug 8, 2022
9.1.x Branch and Release automation moved this from In progress to Ready to Merge Aug 9, 2022
9.2.x Branch and Release automation moved this from In progress to Ready to Merge Aug 9, 2022
@bryancall bryancall merged commit 2f363d9 into master Aug 9, 2022
9.2.x Branch and Release automation moved this from Ready to Merge to Done for 9.2.0 Aug 9, 2022
9.1.x Branch and Release automation moved this from Ready to Merge to For 9.1.3 Aug 9, 2022
masaori335 added a commit to masaori335/trafficserver that referenced this pull request Aug 9, 2022
(cherry picked from commit 2f363d9)

Conflicts:
	proxy/hdrs/Makefile.am
	proxy/hdrs/unit_tests/test_Hdrs.cc
	tests/gold_tests/headers/good_request_after_bad.test.py
	tests/gold_tests/logging/gold/field-json-test.gold
	tests/gold_tests/logging/log-field-json.test.py

Add to run unit test:
	proxy/hdrs/unit_tests/unit_test_main.cc
masaori335 added a commit to masaori335/trafficserver that referenced this pull request Aug 9, 2022
(cherry picked from commit 2f363d9)

Conflicts:
	tests/gold_tests/headers/good_request_after_bad.test.py
	tests/gold_tests/logging/gold/field-json-test.gold
	tests/gold_tests/logging/log-field-json.test.py
bryancall pushed a commit that referenced this pull request Aug 9, 2022
* Fail fast on HTTP/2 header validation (#9009)

(cherry picked from commit eaef5e8)

Conflicts:
	proxy/http2/HTTP2.cc

* Restrict unknown scheme of HTTP/2 request (#9010)

Strictly following RFC 3986 Section 3.1

```
scheme      = ALPHA *( ALPHA / DIGIT / "+" / "-" / "." )
```

(cherry picked from commit c56f872)

Conflicts:
	proxy/http2/HTTP2.cc

* Add control char check in MIME Parser (#9011)

(cherry picked from commit 2f363d9)

Conflicts:
	tests/gold_tests/headers/good_request_after_bad.test.py
	tests/gold_tests/logging/gold/field-json-test.gold
	tests/gold_tests/logging/log-field-json.test.py

* Add content length mismatch check on handling HEADERS frame and CONTINUATION frame (#9012)

* Add content length mismatch check on handling HEADERS frame and CONTINUATION frame

* Correct error class of HTTP/2 malformed requests

(cherry picked from commit e921228)

* Ignore POST request case from a check for background fill (#9013)

(cherry picked from commit 1f3e111)

Co-authored-by: Masakazu Kitajo <maskit@apache.org>
ezelkow1 pushed a commit that referenced this pull request Aug 9, 2022
* Fail fast on HTTP/2 header validation (#9009)

(cherry picked from commit eaef5e8)

Conflicts:
	proxy/http2/HTTP2.cc

* Restrict unknown scheme of HTTP/2 request (#9010)

Strictly following RFC 3986 Section 3.1

```
scheme      = ALPHA *( ALPHA / DIGIT / "+" / "-" / "." )
```

(cherry picked from commit c56f872)

Conflicts:
        proxy/hdrs/unit_tests/test_URL.cc
        proxy/http2/HTTP2.cc

To compile unit tests, Makefile.am is changed too.

* Add control char check in MIME Parser (#9011)

(cherry picked from commit 2f363d9)

Conflicts:
	proxy/hdrs/Makefile.am
	proxy/hdrs/unit_tests/test_Hdrs.cc
	tests/gold_tests/headers/good_request_after_bad.test.py
	tests/gold_tests/logging/gold/field-json-test.gold
	tests/gold_tests/logging/log-field-json.test.py

Add to run unit test:
	proxy/hdrs/unit_tests/unit_test_main.cc

* Add content length mismatch check on handling HEADERS frame and CONTINUATION frame (#9012)

* Add content length mismatch check on handling HEADERS frame and CONTINUATION frame

* Correct error class of HTTP/2 malformed requests

(cherry picked from commit e921228)

* Ignore POST request case from a check for background fill (#9013)

(cherry picked from commit 1f3e111)

Co-authored-by: Masakazu Kitajo <maskit@apache.org>
@bryancall bryancall removed this from For 9.1.3 in 9.1.x Branch and Release Aug 9, 2022
@zwoop
Copy link
Contributor

zwoop commented Aug 10, 2022

Cherry-picked to v9.2.x

@zwoop zwoop removed this from Done for 9.2.0 in 9.2.x Branch and Release Aug 10, 2022
@zwoop zwoop modified the milestones: 10.0.0, 9.2.0 Aug 10, 2022
@masaori335 masaori335 deleted the asf-master-0809-3 branch August 11, 2022 14:07
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Aug 23, 2022
zwoop pushed a commit that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants