Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETHOSN] Implement tanh operator #10241

Closed
wants to merge 1 commit into from

Conversation

spanijel
Copy link
Contributor

Adding compiler support for TANH operator, which is based on
an underlying pattern matching scheme.

One negative test is included as well.

cc @leandron @Leo-arm @mbaret @u99127 for reviews

Copy link
Contributor

@Leo-arm Leo-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor issues. It is not immediately obvious to me why all of the Ethos-N tests are failing; it is likely something to do with the pattern.

tests/python/contrib/test_ethosn/test_tanh.py Outdated Show resolved Hide resolved
src/relay/backend/contrib/ethosn/codegen.cc Outdated Show resolved Hide resolved
@spanijel spanijel force-pushed the add_tanh_to_ethosn branch 4 times, most recently from dba2cbc to d446450 Compare February 21, 2022 09:40
Adding compiler support for TANH operator, which is based on
an underlying pattern matching scheme.

One negative test is included as well.
@manupak
Copy link
Contributor

manupak commented Mar 4, 2022

#10486 supersedes this PR.

@manupak manupak closed this Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants