Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETHOSN] Implement tanh operator #10486

Merged
merged 1 commit into from
Mar 5, 2022
Merged

[ETHOSN] Implement tanh operator #10486

merged 1 commit into from
Mar 5, 2022

Conversation

Leo-arm
Copy link
Contributor

@Leo-arm Leo-arm commented Mar 4, 2022

Adding compiler support for TANH operator, which is based on
an underlying pattern matching scheme.

One negative test is included as well.

Co-authored-by: Samuel Panijel samuel.panijel@arm.com

Adding compiler support for TANH operator, which is based on
an underlying pattern matching scheme.

One negative test is included as well.

Co-authored-by: Samuel Panijel <samuel.panijel@arm.com>
Copy link
Contributor

@manupak manupak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment (can take in a follow up...)

tests/python/contrib/test_ethosn/test_tanh.py Show resolved Hide resolved
Copy link
Contributor

@manupak manupak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@manupak manupak merged commit 9415bea into apache:main Mar 5, 2022
@manupak
Copy link
Contributor

manupak commented Mar 5, 2022

Thanks @Leo-arm !

ziqiangxu8457 pushed a commit to ziqiangxu8457/tvm that referenced this pull request Mar 6, 2022
Adding compiler support for TANH operator, which is based on
an underlying pattern matching scheme.

One negative test is included as well.

Co-authored-by: Samuel Panijel <samuel.panijel@arm.com>

Co-authored-by: Samuel Panijel <samuel.panijel@arm.com>
@Leo-arm Leo-arm deleted the tanh-fix branch March 29, 2022 07:49
pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
Adding compiler support for TANH operator, which is based on
an underlying pattern matching scheme.

One negative test is included as well.

Co-authored-by: Samuel Panijel <samuel.panijel@arm.com>

Co-authored-by: Samuel Panijel <samuel.panijel@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants