[hexagon][testing] add test-skip logic; fixes #11737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cconvey
force-pushed
the
benchmark-tweak
branch
2 times, most recently
from
a755f68
to
da9ac8a
Compare
|
Updated commit message: [hexagon][testing] add test-skip logic; fixes
|
mehrdadh
reviewed
Jun 15, 2022
tests/python/contrib/test_hexagon/test_benchmark_elemwise_add.py
Outdated
Show resolved
Hide resolved
mehrdadh
approved these changes
Jun 16, 2022
mehrdadh
requested changes
Jun 16, 2022
cconvey
force-pushed
the
benchmark-tweak
branch
2 times, most recently
from
52a43e5
to
52e26ef
Compare
- Skip Hexagon benchmarks whenever the env. var `ANDROID_SERIAL_NUMBER` has the value `simulator`. This is a temporary hack to prevent the CI pre-commit hook from running benchmarks, due to the extra time required. - Fix a bug where the elementwise-add benchmark code was broken by an earlier change to the `HexagonLauncherRPC` class. - Rename `benchmark_elemwise_add.py` to `test_benchmark_elemwise_add.py` so that it's noticed by the CI test infrastructure. (CI tests are sometimes run in contexts _other than_ the pre-commit hook.) - Miscellaneous small changes to `tests/python/contrib/test_hexagon/benchmark_util.py`.
mehrdadh
approved these changes
Jun 17, 2022
blackkker
pushed a commit
to blackkker/tvm
that referenced
this pull request
Jul 7, 2022
- Skip Hexagon benchmarks whenever the env. var `ANDROID_SERIAL_NUMBER` has the value `simulator`. This is a temporary hack to prevent the CI pre-commit hook from running benchmarks, due to the extra time required. - Fix a bug where the elementwise-add benchmark code was broken by an earlier change to the `HexagonLauncherRPC` class. - Rename `benchmark_elemwise_add.py` to `test_benchmark_elemwise_add.py` so that it's noticed by the CI test infrastructure. (CI tests are sometimes run in contexts _other than_ the pre-commit hook.) - Miscellaneous small changes to `tests/python/contrib/test_hexagon/benchmark_util.py`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the execution of benchmarks in
benchmark_elemwise_add.pydependon two environment variables:
ANDROID_SERIAL_NUMBERandTVM_FORCE_RUN_BENCHMARKS.By default, the benchmarks are skipped when the
ANDROID_SERIAL_NUMBERenvironment variable has the valuesimulator. (Case is significant.)This can be overridden by setting the environment variable
TVM_FORCE_RUN_BENCHMARKSto the value1.Maintainer note: This is a (hopefully) temporary measure to prevent
(time-consuming) benchmarking code from executing every time TVM's
pre-commit CI hook runs.
Fix a bug where
benchmark_elemwise_add.pywas broken by anearlier change to the
HexagonLauncherRPCclass.misc. small changes to
tests/python/contrib/test_hexagon/benchmark_util.py.cc @mehrdadh