[RPC] Added native debug logging to Android RPC #1432
Conversation
alex-weaver
changed the title
|
cc @eqy can you review this? |
| #include <android/log.h> | ||
|
|
||
| void dmlc::CustomLogMessage::Log(const std::string& msg) { | ||
| __android_log_print(ANDROID_LOG_DEBUG, "TVM_RUNTIME", "%s", msg.c_str()); |
There was a problem hiding this comment.
i guess __android_log_print(ANDROID_LOG_DEBUG, "TVM_RUNTIME", msg.c_str()); can give us what we want without the "%s", ?
There was a problem hiding this comment.
Could simplify like
#define LOGD(MSG) __android_log_print(ANDROID_LOG_DEBUG , "TVM_RUNTIME",MSG);
LOGD("Welcome")
There was a problem hiding this comment.
@jackwish __android_log_print assumes the string is a printf-style format string, so just passing in msg wouldn't work if the log message contained any formatting directives. However, there is an __android_log_write which does do this. I'll get this changed.
There was a problem hiding this comment.
@srkreddy1238 I don't think that preserves the functionality of this PR. The intent is to capture all log messages that TVM generates, and pass them on to logcat. Without this, there is no way to observe the log messages generated by the native TVM code in android app (we would otherwise only see messages from java code).
| @@ -6,6 +6,9 @@ | |||
| #include <sys/stat.h> | |||
| #include <fstream> | |||
|
|
|||
| #define DMLC_LOG_CUSTOMIZE 1 | |||
| #define DMLC_LOG_BEFORE_THROW 1 | |||
There was a problem hiding this comment.
purpose of these macros ?
There was a problem hiding this comment.
DMLC_LOG_CUSTOMIZE is what tells TVM to use the CustomMessage class for logging instead of LogMessage. This requires us to define an implementation for the static function dmlc::CustomLogMessage::Log, which will be invoked for every log that TVM records. This is what allows us to pass the log messages to one of the android logging functions so that they will show up in logcat.
DMLC_LOG_BEFORE_THROW ensures that the log function is invoked before throwing in LogMessageFatal, so that again we have an opportunity to pass the message on to logcat.
see dmlc-core/include/dmlc/logging.h for the implementation of both of these
| #include <android/log.h> | ||
|
|
||
| void dmlc::CustomLogMessage::Log(const std::string& msg) { | ||
| __android_log_print(ANDROID_LOG_DEBUG, "TVM_RUNTIME", "%s", msg.c_str()); |
There was a problem hiding this comment.
Could simplify like
#define LOGD(MSG) __android_log_print(ANDROID_LOG_DEBUG , "TVM_RUNTIME",MSG);
LOGD("Welcome")
|
@srkreddy1238 makes a good comment on clarifying the macros, @alex-weaver can you add two lines of comments? @jackwish please https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly |
tqchen
added
status: review in progress
status: need update
|
THanks @alex-weaver @srkreddy1238 @jackwish This is merged |
tqchen
added
status: accepted
and removed
status: need update
Native code on Android does not automatically forward stdout/stderr to logcat. This PR sets up custom logging so that log messages from TVM are visible in the logcat output. This makes debugging issues in native TVM significantly easier.